Skip to content

Commit 601119d

Browse files
rickymazuston
authored andcommitted
[MINOR] fix: Update outdated config: rss.writer.send.check.timeout -> rss.client.send.check.timeout.ms (apache#1734)
### What changes were proposed in this pull request? Update outdated config: rss.writer.send.check.timeout -> rss.client.send.check.timeout.ms. ### Why are the changes needed? The `rss.writer.send.check.timeout` configuration has been renamed to `rss.client.send.check.timeout.ms`, no longer in use. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? No need.
1 parent 9c996ca commit 601119d

File tree

4 files changed

+4
-4
lines changed

4 files changed

+4
-4
lines changed

README.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -179,7 +179,7 @@ If you have packaged tgz with hadoop jars, the env of `HADOOP_HOME` is needn't s
179179
rss.coordinator.remote.storage.path hdfs://cluster1/path,hdfs://cluster2/path
180180
rss.writer.require.memory.retryMax 1200
181181
rss.client.retry.max 50
182-
rss.writer.send.check.timeout 600000
182+
rss.client.send.check.timeout.ms 600000
183183
rss.client.read.buffer.size 14m
184184
```
185185
5. start Coordinator

client-spark/spark2/src/test/java/org/apache/spark/shuffle/writer/RssShuffleWriterTest.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -133,7 +133,7 @@ public void checkBlockSendResultTest() {
133133
rssShuffleWriter.checkBlockSendResult(Sets.newHashSet(1L, 2L, 3L));
134134
manager.clearTaskMeta(taskId);
135135

136-
// case 2: partial blocks aren't sent before spark.rss.writer.send.check.timeout,
136+
// case 2: partial blocks aren't sent before spark.rss.client.send.check.timeout.ms,
137137
// Runtime exception will be thrown
138138
manager.addSuccessBlockIds(taskId, Sets.newHashSet(1L, 2L));
139139
Throwable e2 =

client-spark/spark3/src/test/java/org/apache/spark/shuffle/writer/RssShuffleWriterTest.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -334,7 +334,7 @@ public void checkBlockSendResultTest() {
334334
rssShuffleWriter.checkBlockSendResult(Sets.newHashSet(1L, 2L, 3L));
335335
successBlocks.clear();
336336

337-
// case 2: partial blocks aren't sent before spark.rss.writer.send.check.timeout,
337+
// case 2: partial blocks aren't sent before spark.rss.client.send.check.timeout.ms,
338338
// Runtime exception will be thrown
339339
successBlocks.put("taskId", Sets.newHashSet(1L, 2L));
340340
Throwable e2 =

docs/coordinator_guide.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ This document will introduce how to deploy Uniffle coordinators.
5858
rss.coordinator.remote.storage.path hdfs://cluster1/path,hdfs://cluster2/path
5959
rss.writer.require.memory.retryMax 1200
6060
rss.client.retry.max 100
61-
rss.writer.send.check.timeout 600000
61+
rss.client.send.check.timeout.ms 600000
6262
rss.client.read.buffer.size 14m
6363
```
6464

0 commit comments

Comments
 (0)