Skip to content

Commit 0439478

Browse files
committed
Address comments
1 parent b69a958 commit 0439478

File tree

1 file changed

+2
-10
lines changed

1 file changed

+2
-10
lines changed

docs/setup_installation/azure/getting_started.md

+2-10
Original file line numberDiff line numberDiff line change
@@ -97,20 +97,12 @@ sleep 30 # give Azure some time to persist the new role
9797
az role assignment create --role hopsfs-storage-permissions --assignee $UA_IDENTITY_PRINCIPAL_ID --scope $STORAGE_ID
9898
```
9999

100-
Also, assign roles to pull/push images from/to the container registry:
101-
102-
```bash
103-
az role assignment create --assignee $UA_IDENTITY_PRINCIPAL_ID --role AcrPull --scope $ACR_ID
104-
az role assignment create --assignee $UA_IDENTITY_PRINCIPAL_ID --role "AcrPush" --scope $ACR_ID
105-
az role assignment create --assignee $UA_IDENTITY_PRINCIPAL_ID --role "AcrDelete" --scope $ACR_ID
106-
```
107-
108100
### Step 1.5: Create Service Principal for Hopsworks services
109101

110102
Create a service principal to grant Hopsworks applications with access to the container registry. For example, Hopsworks uses this service principal to push new Python environments created via the Hopsworks UI.
111103

112104
```bash
113-
export SP_PASSWORD=`az ad sp create-for-rbac --name $SP_NAME --scopes $ACR_ID --role acrpush --query "password" --output tsv`
105+
export SP_PASSWORD=`az ad sp create-for-rbac --name $SP_NAME --scopes $ACR_ID --role acrpush --years 1 --query "password" --output tsv`
114106
export SP_USER_NAME=`az ad sp list --display-name $SP_NAME --query "[].appId" --output tsv`
115107
```
116108

@@ -120,7 +112,7 @@ Provision an AKS cluster with a number of nodes:
120112

121113
```bash
122114
az aks create --resource-group $RESOURCE_GROUP --name $KUBERNETES_CLUSTER_NAME --network-plugin azure \
123-
--enable-cluster-autoscaler --min-count 1 --max-count 4 --node-count 3 --node-vm-size Standard_D16_v4 \
115+
--enable-cluster-autoscaler --min-count 1 --max-count 4 --node-count 3 --node-vm-size Standard_D8_v4 \
124116
--attach-acr $CONTAINER_REGISTRY_NAME \
125117
--assign-identity $UA_IDENTITY_RESOURCE_ID --assign-kubelet-identity $UA_IDENTITY_RESOURCE_ID \
126118
--enable-managed-identity --generate-ssh-keys

0 commit comments

Comments
 (0)