Skip to content

Commit 7790abe

Browse files
authored
[FSTORE-1181] Helper columns should return all columns if they have different names across feature groups (#341)
Helper columns should return all columns if they have different names across feature groups
1 parent 0795b38 commit 7790abe

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

docs/user_guides/fs/feature_view/batch-data.md

+2-1
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,8 @@ To retrieve the primary key(s) and/or event time when retrieving batch data for
3232
) # return a dataframe with primary keys and event time
3333
```
3434
!!! note
35-
If the event time columns have the same name across all the feature groups included in the feature view, then only the event time of the label feature group (left most feature group in the query) will be returned. If they have different names, then all of them will be returned. The Join prefix does not have any influence on this behaviour.
35+
All primary and event time columns of all the feature groups included in the feature view will be returned. If they have the same names across feature groups and the join prefix was not provided then reading operation will fail with ambiguous column exception.
36+
Make sure to define the join prefix if primary key and event time columns have the same names across feature groups.
3637

3738
For Python-clients, handling small or moderately-sized data, we recommend enabling the [ArrowFlight Server with DuckDB](../../../setup_installation/common/arrow_flight_duckdb.md), which will provide significant speedups over Spark/Hive for reading batch data.
3839
If the service is enabled, and you want to read this particular batch data with Hive instead, you can set the read_options to `{"use_hive": True}`.

docs/user_guides/fs/feature_view/training-data.md

+2-1
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,8 @@ X_train, X_test, y_train, y_test = feature_view.get_train_test_split(training_da
108108
```
109109

110110
!!! note
111-
If the event time columns have the same name across all the feature groups included in the feature view, then only the event time of the label feature group (left most feature group in the query) will be returned. If they have different names, then all of them will be returned. The Join prefix does not have any influence on this behaviour.
111+
All primary and event time columns of all the feature groups included in the feature view will be returned. If they have the same names across feature groups and the join prefix was not provided then reading operation will fail with ambiguous column exception.
112+
Make sure to define the join prefix if primary key and event time columns have the same names across feature groups.
112113

113114
To use primary key(s) and event time column with materialized training datasets it needs to be created with `primary_keys=True` and/or `with_event_time=True`.
114115

0 commit comments

Comments
 (0)