Skip to content

Commit f36a76f

Browse files
committed
fix review comments
1 parent 7f181c1 commit f36a76f

File tree

3 files changed

+12
-8
lines changed

3 files changed

+12
-8
lines changed
Loading
Binary file not shown.

docs/user_guides/fs/storage_connector/creation/jdbc.md

+12-8
Original file line numberDiff line numberDiff line change
@@ -43,18 +43,22 @@ Enter the details for your JDBC enabled database.
4343

4444
1. Select "JDBC" as connector protocol.
4545
2. Enter the JDBC connection url. This can for example also contain the username and password.
46-
6. Add driver class name as an argument. This is a mandatory argument even if using default MySQL driver. Add an argument with name `driver` and driver class name as value. For MySQL databases, the class name is `com.mysql.cj.jdbc.Driver`, as shown in example below. The driver class name will differ based on the database to connect.
47-
3. Add additional key/value arguments to be passed to the connection. These might differ by database. It can be the username and password. Passwords are encrypted as [Secret](../../../projects/secrets/create_secret.md) and stored in the database for additional security.
48-
4. Click "Setup storage connector".
46+
3. Add additional key/value arguments to be passed to the connection. These might differ by database. It can be the username and password.
4947

50-
<figure markdown>
51-
![Adding Driver in arguments](../../../../assets/images/guides/fs/storage_connector/jdbc_driver.png)
52-
<figcaption>Specifying driver name in case of MySQL</figcaption>
53-
</figure>
48+
49+
!!! note
50+
Add driver class name as an argument. This is a mandatory argument even if using default MySQL driver. Add an argument with name `driver` and class name as value. The driver class name will differ based on the database to connect. For MySQL databases, the class name is `com.mysql.cj.jdbc.Driver`, as shown in example image.
51+
52+
53+
4. Click "Setup storage connector".
5454

5555

5656
!!! note
57-
To be able to use the connector, you need to upload the driver JAR file to the [Jupyter configuration](../../../projects/jupyter/spark_notebook.md) or to a [Job configuration](../../../projects/jobs/pyspark_job.md) in `Addtional Jars`. However, for MySQL connections the default JDBC driver is included in Hopsworks so this step can skipped.
57+
To be able to use the connector, you need to upload the driver JAR file to the [Jupyter configuration](../../../projects/jupyter/spark_notebook.md) or to a [Job configuration](../../../projects/jobs/pyspark_job.md) in `Addtional Jars`. However, for MySQL connections the default JDBC driver is included in Hopsworks so this step can skipped.
58+
59+
60+
!!! info
61+
Passwords are encrypted as [Secret](../../../projects/secrets/create_secret.md) and stored in the database for additional security.
5862

5963
## Next Steps
6064

0 commit comments

Comments
 (0)