[FSTORE-1147] Online feature store notification system #343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SirOibaf
requested changes
Feb 14, 2024
bubriks
commented
Feb 14, 2024
| { | ||
| "projectId":119, # project used for data ingestion | ||
| "featureStoreId":67, # feature store where changes took place | ||
| "featureGroupId":14, # feature group changed |
There was a problem hiding this comment.
noticed that we dont provide name/version for FG should we make an update to do it like we do for FV?
|
|
||
| The notification topic name can be changed after the creation of the feature group. | ||
| By setting the `notification_topic_name` value to `None` or empty string notification will be disabled. | ||
| With the default configuration, it can take up to 30 minutes for these changes to take place since the onlinefs service internally caches feature groups. |
There was a problem hiding this comment.
in onlinefs it is set like this: .expireAfterAccess(30, TimeUnit.MINUTES)
so user would not be able to change it (same for all cached entries), should we enable user changing this value?
There was a problem hiding this comment.
also it might be better to change them from expireAfterAccess (this includes last access, so if user constantly writes it might not expire ever) to expireAfterWrite
There was a problem hiding this comment.
Yeah It should be a configurable parameter.
SirOibaf
approved these changes
Feb 16, 2024
SirOibaf
added a commit
that referenced
this pull request
Feb 16, 2024
Co-authored-by: Fabio Buso <fabio@hopsworks.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.