[FSTORE-1095] update driver dependecies and secrets feature #350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bubriks
requested changes
Feb 22, 2024
Co-authored-by: Ralf <bubriks@gmail.com>
bubriks
requested changes
Feb 22, 2024
Co-authored-by: Ralf <bubriks@gmail.com>
Co-authored-by: Ralf <bubriks@gmail.com>
Co-authored-by: Ralf <bubriks@gmail.com>
bubriks
approved these changes
Feb 22, 2024
SirOibaf
reviewed
Feb 22, 2024
|
|
||
|
|
||
| !!! note | ||
| Driver class name is a mandatory argument even if using the default MySQL driver. Add it by specifying a property with the name `driver` and class name as value. The driver class name will differ based on the database. For MySQL databases, the class name is `com.mysql.cj.jdbc.Driver`, as shown in the example image. |
There was a problem hiding this comment.
@dhananjay-mk in the screenshot the property name is Driver with the capital D, here it's lower case, does it matter?
There was a problem hiding this comment.
also the formatting is wrong, note should be indented twice
SirOibaf
reviewed
Feb 22, 2024
Comment on lines
56
to
57
| !!! note | ||
| To be able to use the connector, you need to upload the driver JAR file to the [Jupyter configuration](../../../projects/jupyter/spark_notebook.md) or [Job configuration](../../../projects/jobs/pyspark_job.md) in `Addtional Jars`. For MySQL connections the default JDBC driver is already included in Hopsworks so this step can be skipped. |
There was a problem hiding this comment.
Formatting here is wrong, notes content should be indented twice
SirOibaf
reviewed
Feb 22, 2024
Comment on lines
60
to
61
| !!! info | ||
| Passwords are encrypted as [Secret](../../../projects/secrets/create_secret.md) and stored in the database for additional security. |
There was a problem hiding this comment.
this is a given imho, we don't need to document it.
SirOibaf
pushed a commit
that referenced
this pull request
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update JDBC connector for driver dependencies.
JIRA https://hopsworks.atlassian.net/browse/FSTORE-1095