Update instructions for exporting Prometheus metrics #446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SirOibaf
approved these changes
Mar 5, 2025
| We will only give a sample configuration as `remote_write` is extensively documented in Prometheus [documentation](https://prometheus.io/docs/prometheus/latest/configuration/configuration/#remote_write) | ||
| In the example below we push metrics to a custom service listening on port 9096 which transforms the metrics and forwards them. | ||
|
|
||
| #### Step 1 |
There was a problem hiding this comment.
Is this really a good idea? The config map will be overwritten with the next helm upgrade.
Looks like it's possible to configure the remoteWrite from the helm repo:
https://github.com/prometheus-community/helm-charts/blob/fe79476450db94f79d65c4863d63484c26a12037/charts/prometheus/values.yaml#L280C3-L280C14
I think we should change the below intructions to tell users to add this configuration in the values.yaml file.
There was a problem hiding this comment.
True, that's better. I'll change the instructions
kouzant
force-pushed
the
federate_prometheus
branch
from
ff61f91 to
f710a09
Compare
kouzant
added a commit
to kouzant/logicalclocks.github.io
that referenced
this pull request
Mar 14, 2025
kouzant
added a commit
that referenced
this pull request
Mar 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.