Skip to content

Commit 062758e

Browse files
authored
refactor: storybook & linter (#268)
* update some libs * sort out `no-extraneous-dependencies` rule added this rule into `.eslintrc` removed ignore comments for this rule
1 parent c559b37 commit 062758e

32 files changed

+1439
-1045
lines changed

.eslintrc

+6
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,12 @@
2424
}
2525
},
2626
"rules": {
27+
/* quartz is a library with peer dependencies, so we do not need this rule to trigger on extraneous deps specified in `package.json/peerDependencies` */
28+
"import/no-extraneous-dependencies": [
29+
"error",
30+
{ "peerDependencies": false }
31+
],
32+
2733
"react-hooks/exhaustive-deps": "error",
2834
"space-before-function-paren": 0,
2935
"react/prop-types": 0,

package.json

+6-6
Original file line numberDiff line numberDiff line change
@@ -44,10 +44,10 @@
4444
"@semantic-release/github": "^8.0.2",
4545
"@semantic-release/npm": "^9.0.1",
4646
"@semantic-release/release-notes-generator": "^10.0.3",
47-
"@storybook/addon-actions": "^6.4.19",
48-
"@storybook/addon-essentials": "^6.4.19",
49-
"@storybook/addon-links": "^6.4.19",
50-
"@storybook/react": "^6.4.19",
47+
"@storybook/addon-actions": "^6.5.9",
48+
"@storybook/addon-essentials": "^6.5.9",
49+
"@storybook/addon-links": "^6.5.9",
50+
"@storybook/react": "^6.5.9",
5151
"@types/node": "^12.12.38",
5252
"@types/ramda": "^0.28.1",
5353
"@types/rc-slider": "^8.6.6",
@@ -56,8 +56,8 @@
5656
"@types/react-dom": "^16.9.14",
5757
"@types/rebass": "^4.0.10",
5858
"@types/rebass__forms": "^4.0.6",
59-
"@typescript-eslint/eslint-plugin": "^5.14.0",
60-
"@typescript-eslint/parser": "^5.14.0",
59+
"@typescript-eslint/eslint-plugin": "^5.29.0",
60+
"@typescript-eslint/parser": "^5.29.0",
6161
"chromatic": "^5.10.2",
6262
"commitizen": "^4.2.4",
6363
"cross-env": "^7.0.3",

src/components/alternative-header/alternative-header.stories.tsx

-1
Original file line numberDiff line numberDiff line change
@@ -139,7 +139,6 @@ Default.argTypes = {
139139
control: {
140140
type: 'text',
141141
},
142-
143142
type: {
144143
summary: 'Card width (string or number px, %)',
145144
},

src/components/button/button.stories.tsx

-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
// eslint-disable-next-line import/no-extraneous-dependencies
21
import { action } from '@storybook/addon-actions';
32
import React from 'react';
43
import { Story, Meta } from '@storybook/react/types-6-0';

src/components/callout/callout.stories.tsx

-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
import React from 'react';
22
import { Story, Meta } from '@storybook/react/types-6-0';
3-
// eslint-disable-next-line import/no-extraneous-dependencies
43
import { action } from '@storybook/addon-actions';
54
import { Box } from 'rebass';
65
import Callout, { ICalloutProps, CalloutTypes } from './index';

src/components/card-header/card-header.stories.tsx

-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
// eslint-disable-next-line import/no-extraneous-dependencies
21
import { action } from '@storybook/addon-actions';
32

43
import { Box, Button } from 'rebass';

src/components/card/card.stories.tsx

+1-4
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,6 @@
1-
// eslint-disable-next-line import/no-extraneous-dependencies
21
import { action } from '@storybook/addon-actions';
3-
// eslint-disable-next-line import/no-extraneous-dependencies
4-
import { ArgTypes } from '@storybook/addons';
52
import React from 'react';
6-
import { Story, Meta } from '@storybook/react/types-6-0';
3+
import { Story, Meta, ArgTypes } from '@storybook/react/types-6-0';
74

85
import Card, { CardProps } from '.';
96
import Button from '../button';

src/components/code-input/index.stories.tsx

-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
// eslint-disable-next-line import/no-extraneous-dependencies
21
import { action } from '@storybook/addon-actions';
32
import { Meta, Story } from '@storybook/react/types-6-0';
43
import React from 'react';

src/components/dropdown/dropdown.stories.tsx

-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
// eslint-disable-next-line import/no-extraneous-dependencies
21
import { action } from '@storybook/addon-actions';
32
import React from 'react';
43
import { Box } from 'rebass';

src/components/editableSelect/editableSelect.stories.tsx

-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
import React, { useState } from 'react';
22
import { Story, Meta } from '@storybook/react/types-6-0';
3-
// eslint-disable-next-line import/no-extraneous-dependencies
43
import { action } from '@storybook/addon-actions';
54
import { Box } from 'rebass';
65

src/components/file-button/file-button.stories.tsx

-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
// eslint-disable-next-line import/no-extraneous-dependencies
21
import { action } from '@storybook/addon-actions';
32
import React from 'react';
43
import { Story, Meta } from '@storybook/react/types-6-0';

src/components/file-loader/file-loader.stories.tsx

-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
// eslint-disable-next-line import/no-extraneous-dependencies
21
import React from 'react';
32
import { Story, Meta } from '@storybook/react/types-6-0';
43

src/components/file-system-explorer/file-system-explorer.stories.tsx

-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
// eslint-disable-next-line import/no-extraneous-dependencies
21
import { action } from '@storybook/addon-actions';
32
import React from 'react';
43
import { Story, Meta } from '@storybook/react/types-6-0';

src/components/file-system-explorer/file/file-explorer.stories.tsx

-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
// // eslint-disable-next-line import/no-extraneous-dependencies
21
// import React from 'react';
32
// import { Story, Meta } from '@storybook/react/types-6-0';
43
//

src/components/file-system-explorer/folder/folder-explorer.stories.tsx

-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
// // eslint-disable-next-line import/no-extraneous-dependencies
21
// import React from 'react';
32
// import { Story, Meta } from '@storybook/react/types-6-0';
43
//

src/components/footer-button/footer-button.stories.tsx

-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
// eslint-disable-next-line import/no-extraneous-dependencies
21
import { action } from '@storybook/addon-actions';
32
import React from 'react';
43
import { Story, Meta } from '@storybook/react/types-6-0';

src/components/form-tabs/form-tabs.stories.tsx

-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
import React from 'react';
2-
// eslint-disable-next-line import/no-extraneous-dependencies
32
import { action } from '@storybook/addon-actions';
43
import { Story, Meta } from '@storybook/react/types-6-0';
54
import { Box } from 'rebass';

src/components/form-tabs/index.tsx

-1
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@ import React, {
77
useState,
88
} from 'react';
99
import { Box, Flex } from 'rebass';
10-
// eslint-disable-next-line import/no-extraneous-dependencies
1110
import ResizeObserver from 'resize-observer-polyfill';
1211
import {
1312
summaryContainerStyles,

src/components/form-tabs/tab/tab.stories.tsx

-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
// eslint-disable-next-line import/no-extraneous-dependencies
21
import { action } from '@storybook/addon-actions';
32
import React from 'react';
43
import { Story, Meta } from '@storybook/react/types-6-0';

src/components/icon-button/icon-button.stories.tsx

-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
import React from 'react';
2-
// eslint-disable-next-line import/no-extraneous-dependencies
32
import { action } from '@storybook/addon-actions';
43
import { Story, Meta } from '@storybook/react/types-6-0';
54

src/components/input/input.stories.tsx

-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
// eslint-disable-next-line import/no-extraneous-dependencies
21
import { action } from '@storybook/addon-actions';
32
import { Meta, Story } from '@storybook/react/types-6-0';
43
import React from 'react';

src/components/label/label.stories.tsx

-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
// eslint-disable-next-line import/no-extraneous-dependencies
21
import React from 'react';
32
import { Story, Meta } from '@storybook/react/types-6-0';
43

src/components/navigation/navigation.stories.tsx

-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
import React from 'react';
22
import { Box } from 'rebass';
3-
// eslint-disable-next-line import/no-extraneous-dependencies
43
import { action } from '@storybook/addon-actions';
54
import { Story, Meta } from '@storybook/react/types-6-0';
65

src/components/pagination/pagination.stories.tsx

-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
// eslint-disable-next-line import/no-extraneous-dependencies
21
import { action } from '@storybook/addon-actions';
32
import React, { useState } from 'react';
43
import { Story, Meta } from '@storybook/react/types-6-0';

src/components/performance-bar/performance-bar.stories.tsx

-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
// eslint-disable-next-line import/no-extraneous-dependencies
21
import React from 'react';
32
import { Story, Meta } from '@storybook/react/types-6-0';
43
import PerformanceBar, { PerformanceBarProps } from '.';

src/components/performance-card/performance-card.stories.tsx

-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
// eslint-disable-next-line import/no-extraneous-dependencies
21
import React from 'react';
32
import { Story, Meta } from '@storybook/react/types-6-0';
43
import Labeling from '../typography/labeling';

src/components/popup/popup.stories.tsx

-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
// eslint-disable-next-line import/no-extraneous-dependencies
21
import { action } from '@storybook/addon-actions';
32
import React from 'react';
43
import { Story, Meta } from '@storybook/react/types-6-0';

src/components/row/row.stories.tsx

-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
import React from 'react';
22
import { Box } from 'rebass';
33
import { Story, Meta } from '@storybook/react/types-6-0';
4-
// eslint-disable-next-line import/no-extraneous-dependencies
54
import { action } from '@storybook/addon-actions';
65
import Row, { RowProps } from './container';
76
import RowGroup, { RowGroupProps } from './group';

src/components/select/select.stories.tsx

-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
// eslint-disable-next-line import/no-extraneous-dependencies
21
import { action } from '@storybook/addon-actions';
32
import React, { useState } from 'react';
43
import { Story, Meta } from '@storybook/react/types-6-0';

src/components/select2/select.stories.tsx

-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
// eslint-disable-next-line import/no-extraneous-dependencies
21
import { action } from '@storybook/addon-actions';
32
import React, { useState } from 'react';
43
import { Story, Meta } from '@storybook/react/types-6-0';

src/components/spinner/spinner.stories.tsx

-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
// eslint-disable-next-line import/no-extraneous-dependencies
21
import React from 'react';
32
import { Story, Meta } from '@storybook/react/types-6-0';
43
import Spinner, { SpinnerProps } from '.';

0 commit comments

Comments
 (0)