Skip to content

Commit 9c9d1d6

Browse files
committed
Directly use image name X86_IMAGE_NAME
1 parent 069c539 commit 9c9d1d6

File tree

1 file changed

+19
-20
lines changed

1 file changed

+19
-20
lines changed

.github/workflows/build_test_push.yaml

+19-20
Original file line numberDiff line numberDiff line change
@@ -139,11 +139,11 @@ jobs:
139139
- name: Build and run Docker Compose cluster with benchmarking
140140
if: ${{ !inputs.skip_test }}
141141
run: |
142-
MULTI_IMAGE_NAME="${{ needs.process-info.outputs.multi_image_name }}"
142+
X86_IMAGE_NAME="${{ needs.process-info.outputs.x86_image_name }}"
143143
144144
./run.sh -lv \
145145
--rondb-version ${{ inputs.rondb_version }} \
146-
--rondb-image-name $MULTI_IMAGE_NAME \
146+
--rondb-image-name $X86_IMAGE_NAME \
147147
--rondb-tarball-url ${{ inputs.base_download_url }}/${{ inputs.rondb_x86_tarball_name }} \
148148
--size mini \
149149
--run-benchmark sysbench_single \
@@ -208,10 +208,10 @@ jobs:
208208
if: ${{ inputs.skip_test && github.repository == 'logicalclocks/rondb-docker' && (startsWith(github.ref_name, 'release-') || github.ref_name == 'main')}}
209209
run: |
210210
VERSION="$(sed -e 's/^[[:space:]]*//' -e '/-SNAPSHOT$/s/.*/dev/' ./VERSION)"
211-
MULTI_IMAGE_NAME="${{ needs.process-info.outputs.multi_image_name }}"
211+
X86_IMAGE_NAME="${{ needs.process-info.outputs.x86_image_name }}"
212212
213213
docker buildx build . \
214-
--tag $MULTI_IMAGE_NAME:${{ inputs.rondb_version }}-$VERSION \
214+
--tag $X86_IMAGE_NAME:${{ inputs.rondb_version }}-$VERSION \
215215
--build-arg RONDB_VERSION=${{ inputs.rondb_version }} \
216216
--build-arg RONDB_TARBALL_LOCAL_REMOTE=remote \
217217
--build-arg RONDB_X86_TARBALL_URI=${{ inputs.base_download_url }}/${{ inputs.rondb_x86_tarball_name }}
@@ -222,12 +222,12 @@ jobs:
222222
VERSION="$(sed -e 's/^[[:space:]]*//' -e '/-SNAPSHOT$/s/.*/dev/' ./VERSION)"
223223
224224
X86_IMAGE_NAME="${{ needs.process-info.outputs.x86_image_name }}"
225-
MULTI_IMAGE_NAME="${{ needs.process-info.outputs.multi_image_name }}"
225+
TAG=${{ inputs.rondb_version }}-$VERSION
226226
227-
IMAGE_NAME=hopsworks/$X86_IMAGE_NAME:${{ inputs.rondb_version }}-$VERSION
227+
NEW_IMAGE_ID=hopsworks/$X86_IMAGE_NAME:$TAG
228228
229-
docker tag $MULTI_IMAGE_NAME:${{ inputs.rondb_version }}-$VERSION $IMAGE_NAME
230-
docker push $IMAGE_NAME
229+
docker tag $X86_IMAGE_NAME:$TAG $NEW_IMAGE_ID
230+
docker push $NEW_IMAGE_ID
231231
232232
- name: Push with tag `<rondb-version>-latest`
233233
# Our "latest" branch points to the latest *release* branch.
@@ -236,25 +236,25 @@ jobs:
236236
VERSION="$(sed -e 's/^[[:space:]]*//' -e '/-SNAPSHOT$/s/.*/dev/' ./VERSION)"
237237
238238
X86_IMAGE_NAME="${{ needs.process-info.outputs.x86_image_name }}"
239-
MULTI_IMAGE_NAME="${{ needs.process-info.outputs.multi_image_name }}"
239+
TAG=${{ inputs.rondb_version }}-$VERSION
240240
241-
IMAGE_NAME=hopsworks/$X86_IMAGE_NAME:${{ inputs.rondb_version }}-latest
241+
NEW_IMAGE_ID=hopsworks/$X86_IMAGE_NAME:${{ inputs.rondb_version }}-latest
242242
243-
docker tag $MULTI_IMAGE_NAME:${{ inputs.rondb_version }}-$VERSION $IMAGE_NAME
244-
docker push $IMAGE_NAME
243+
docker tag $X86_IMAGE_NAME:$TAG $NEW_IMAGE_ID
244+
docker push $NEW_IMAGE_ID
245245
246246
- name: Push with tag `latest`
247247
if: ${{ needs.process-info.outputs.is_highest_release && inputs.is_latest_rondb_release }}
248248
run: |
249249
VERSION="$(sed -e 's/^[[:space:]]*//' -e '/-SNAPSHOT$/s/.*/dev/' ./VERSION)"
250250
251-
X86_IMAGE_NAME="${{ needs.process-info.outputs.x86_image_name }}"
252-
MULTI_IMAGE_NAME="${{ needs.process-info.outputs.multi_image_name }}"
253-
254-
IMAGE_NAME=hopsworks/$X86_IMAGE_NAME:latest
251+
X86_IMAGE_NAME="${{ needs.process-info.outputs.x86_image_name }}"
252+
TAG=${{ inputs.rondb_version }}-$VERSION
253+
254+
NEW_IMAGE_ID=hopsworks/$X86_IMAGE_NAME:latest
255255
256-
docker tag $MULTI_IMAGE_NAME:${{ inputs.rondb_version }}-$VERSION $IMAGE_NAME
257-
docker push $IMAGE_NAME
256+
docker tag $X86_IMAGE_NAME:$TAG $NEW_IMAGE_ID
257+
docker push $NEW_IMAGE_ID
258258
259259
build-push-arm64:
260260
runs-on: ubuntu-latest
@@ -280,10 +280,9 @@ jobs:
280280
# all types of benchmarking to the tests.
281281
- name: Build and push ARM64 image
282282
run: |
283+
VERSION="$(sed -e 's/^[[:space:]]*//' -e '/-SNAPSHOT$/s/.*/dev/' ./VERSION)"
283284
ARM_IMAGE_NAME="${{ needs.process-info.outputs.arm_image_name }}"
284-
MULTI_IMAGE_NAME="${{ needs.process-info.outputs.multi_image_name }}"
285285
286-
VERSION="$(sed -e 's/^[[:space:]]*//' -e '/-SNAPSHOT$/s/.*/dev/' ./VERSION)"
287286
TAGS="--tag hopsworks/$ARM_IMAGE_NAME:${{ inputs.rondb_version }}-$VERSION"
288287
if [[ "${{ needs.process-info.outputs.is_highest_release }}" == "true" ]]; then
289288
TAGS+=" --tag hopsworks/$ARM_IMAGE_NAME:${{ inputs.rondb_version }}-latest"

0 commit comments

Comments
 (0)