Attempt to use booleans for input again

Author: olapiv

.github/workflows/build_test_push.yaml

@@ -2,9 +2,7 @@ name: Build, test & push executor
 
 on:
   workflow_call:
-    # WARNING:
-    #   1. Duplicate everything here into workflow_dispatch
-    #   2. Type "boolean" is not supported
+    # WARNING: Duplicate everything here into workflow_dispatch
     inputs:
       rondb_version:
         required: true
@@ -18,12 +16,12 @@ on:
       is_latest_rondb_release:
         required: true
         description: "Used to decide whether the Docker image will be using the 'latest' tag without a version number"
-        type: string
-        default: 'false'
+        type: boolean
+        default: false
       skip_test:
         required: true
-        type: string
-        default: 'false'
+        type: boolean
+        default: false
   # Inputs here have to be duplicated from workflow_call...
   # https://github.com/orgs/community/discussions/39357
   workflow_dispatch:
@@ -40,12 +38,12 @@ on:
       is_latest_rondb_release:
         required: true
         description: "Used to decide whether the Docker image will be using the 'latest' tag without a version number"
-        type: string
-        default: 'false'
+        type: boolean
+        default: false
       skip_test:
         required: true
-        type: string
-        default: 'false'
+        type: boolean
+        default: false
 
 env:
   BASE_DOWNLOAD_URL: https://repo.hops.works/master
@@ -57,7 +55,7 @@ jobs:
     runs-on: ubuntu-latest
     # This will block all other jobs from running due to "needs"
     if: |
-      ${{ inputs.skip_test == 'false' || (
+      ${{ !inputs.skip_test || (
           github.repository == 'logicalclocks/rondb-docker' && 
           (startsWith(github.ref_name, 'release-') || github.ref_name == 'main')
       )}}
@@ -96,7 +94,7 @@ jobs:
           password: ${{ secrets.DOCKERHUB_TOKEN }}
 
       - name: Build and run Docker Compose cluster with benchmarking
-        if: ${{ inputs.skip_test == 'false' }}
+        if: ${{ !inputs.skip_test }}
         run: |
           ./run.sh -lv \
             --rondb-tarball-url $BASE_DOWNLOAD_URL/${{ inputs.rondb_x86_tarball_name }} \
@@ -106,7 +104,7 @@ jobs:
             --detached
 
       - name: Wait for one container exit or timeout
-        if: ${{ inputs.skip_test == 'false' }}
+        if: ${{ !inputs.skip_test }}
         run: |
           start=`date +%s`
           while true; do
@@ -125,24 +123,24 @@ jobs:
           done
 
       - run: docker container ls
-        if: ${{ inputs.skip_test == 'false' }}
+        if: ${{ !inputs.skip_test }}
       - run: docker logs mgmd_1
-        if: ${{ inputs.skip_test == 'false' }}
+        if: ${{ !inputs.skip_test }}
       - run: docker logs ndbd_1
-        if: ${{ inputs.skip_test == 'false' }}
+        if: ${{ !inputs.skip_test }}
       - run: docker logs mysqld_1
-        if: ${{ inputs.skip_test == 'false' }}
+        if: ${{ !inputs.skip_test }}
       - run: docker logs rest_1
-        if: ${{ inputs.skip_test == 'false' }}
+        if: ${{ !inputs.skip_test }}
       - run: docker logs bench_1
-        if: ${{ inputs.skip_test == 'false' }}
+        if: ${{ !inputs.skip_test }}
 
       # At this point we only know that one container has exited. We want to
       # check whether the bench container has exited with exit code 0. We need
       # both status and exit code to do so, since Docker reports exit code 0
       # for running containers.
       - name: Check Benchmarking Exit Code
-        if: ${{ inputs.skip_test == 'false' }}
+        if: ${{ !inputs.skip_test }}
         run: |
           if [ "$(docker inspect bench_1 --format='{{.State.Status}}')" != "exited" ]
           then
@@ -157,11 +155,11 @@ jobs:
           fi
 
       - name: Printing Sysbench results
-        if: ${{ inputs.skip_test == 'false' }}
+        if: ${{ !inputs.skip_test }}
         run: cat autogenerated_files/*/volumes/sysbench_single/final_result.txt
 
       - name: Build X86 image
-        if: ${{ inputs.skip_test == 'true' && github.repository == 'logicalclocks/rondb-docker' && (startsWith(github.ref_name, 'release-') || github.ref_name == 'main')}}
+        if: ${{ inputs.skip_test && github.repository == 'logicalclocks/rondb-docker' && (startsWith(github.ref_name, 'release-') || github.ref_name == 'main')}}
         run: |
           VERSION="$(sed -e 's/^[[:space:]]*//' -e '/-SNAPSHOT$/s/.*/dev/' ./VERSION)"
           docker buildx build . \
@@ -190,7 +188,7 @@ jobs:
           docker push $IMAGE_NAME
 
       - name: Push with tag `latest`
-        if: ${{ needs.check-git.outputs.is_highest_release == 'true' && inputs.is_latest_rondb_release == 'true' }}
+        if: ${{ needs.check-git.outputs.is_highest_release && inputs.is_latest_rondb_release }}
         run: |
           VERSION="$(sed -e 's/^[[:space:]]*//' -e '/-SNAPSHOT$/s/.*/dev/' ./VERSION)"
           IMAGE_NAME=hopsworks/$X86_IMAGE_NAME:latest

.github/workflows/main.yml

@@ -20,15 +20,15 @@ jobs:
       matrix:
         info:
           - rondb_version: 21.04.16
-            is_latest_rondb_release: 'false'
+            is_latest_rondb_release: false
             glibc_version_x86: 2.17
             glibc_version_arm64: 2.35
-            skip_test: 'true'
+            skip_test: true
           - rondb_version: 22.10.3
-            is_latest_rondb_release: 'true'
+            is_latest_rondb_release: true
             glibc_version_x86: 2.28
             glibc_version_arm64: 2.28
-            skip_test: 'false'
+            skip_test: false
     with:
       rondb_version: ${{ matrix.info.rondb_version }}
       is_latest_rondb_release: ${{ matrix.info.is_latest_rondb_release }}