Skip to content

[RACL] Deduplicate RACL templates #26146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 25, 2025
Merged

[RACL] Deduplicate RACL templates #26146

merged 1 commit into from
Feb 25, 2025

Conversation

davidschrammel
Copy link
Contributor

@davidschrammel davidschrammel commented Feb 6, 2025 •
edited
Loading

This PR:

  • deduplicates all of the RACL templates and consolidates them into two separate files
  • allows including template files within other templates
  • updates lowrisc_misc_linters to the latest version to allow for comments within .tpl files (which are needed for the license checker)

@davidschrammel davidschrammel force-pushed the racl-fixes-2 branch 2 times, most recently from 58c6a9a to 0db15f3 Compare February 6, 2025 11:46
@davidschrammel davidschrammel requested a review from Razer6 February 6, 2025 11:46
Razer6
Razer6 reviewed Feb 6, 2025
View reviewed changes
Razer6
Razer6 reviewed Feb 6, 2025
View reviewed changes
Razer6
Razer6 reviewed Feb 6, 2025
View reviewed changes
@davidschrammel davidschrammel force-pushed the racl-fixes-2 branch 6 times, most recently from 24775b9 to 4b3d21b Compare February 11, 2025 10:46
@davidschrammel davidschrammel marked this pull request as ready for review February 13, 2025 14:13
@davidschrammel davidschrammel mentioned this pull request Feb 13, 2025
Merged
@davidschrammel davidschrammel requested review from andreaskurth and removed request for msfschaffner February 14, 2025 14:42
andreaskurth
andreaskurth reviewed Feb 17, 2025
View reviewed changes
Copy link
Contributor

@andreaskurth andreaskurth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small comments, otherwise LGTM

andreaskurth
andreaskurth approved these changes Feb 17, 2025
View reviewed changes
Copy link
Contributor

@andreaskurth andreaskurth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx @davidschrammel

@davidschrammel davidschrammel mentioned this pull request Feb 25, 2025
Merged
@davidschrammel
[racl,raclgen,topgen] Deduplicate RACL templates
d7dae9e 
Signed-off-by: David Schrammel <davidschrammel@rivosinc.com>
@andreaskurth andreaskurth merged commit 22cbfa1 into lowRISC:master Feb 25, 2025
42 checks passed
@davidschrammel davidschrammel mentioned this pull request Feb 27, 2025
Merged
@davidschrammel davidschrammel deleted the racl-fixes-2 branch March 31, 2025 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Razer6 Razer6 Razer6 left review comments

@andreaskurth andreaskurth andreaskurth approved these changes

@rswarbrick rswarbrick Awaiting requested review from rswarbrick

@a-will a-will Awaiting requested review from a-will

@vogelpi vogelpi Awaiting requested review from vogelpi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davidschrammel @Razer6 @andreaskurth