Skip to content

[topgen] Rename data_defs.tpl to data_defs.bzl.tpl for license checker #26151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 11, 2025

Conversation

davidschrammel
Copy link
Contributor

@davidschrammel davidschrammel commented Feb 6, 2025

Previously, the comment style definition for Mako template files was incorrect and the license checker did not recognize this file as a Bazel file.

This PR is related to misc-linters#41 but does not depend on it.

Signed-off-by: David Schrammel <davidschrammel@rivosinc.com>
Copy link
Contributor

@rswarbrick rswarbrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much cleaner! Thanks.

@rswarbrick rswarbrick merged commit f3b2425 into lowRISC:master Feb 11, 2025
39 checks passed
@davidschrammel davidschrammel deleted the license-checker-fix-1 branch March 31, 2025 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants