[RACL] Correct ordering of policy selection vectors #26421
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidschrammel
force-pushed
the
racl-fixes-5-ordering
branch
from
e2e6ae5 to
37c9e54
Compare
davidschrammel
requested review from
andreaskurth
and removed request for
msfschaffner
andreaskurth
approved these changes
Feb 25, 2025
There was a problem hiding this comment.
LGTM, thanks. Please rebase this PR now that #26146 is merged.
Signed-off-by: David Schrammel <davidschrammel@rivosinc.com>
davidschrammel
force-pushed
the
racl-fixes-5-ordering
branch
from
37c9e54 to
de65280
Compare
|
The failure of the CW305 bitstream CI check isn't related to the changes in this PR; merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue with the ordering of the policy selection vectors when using non-
*mappings.With the default racl configuration this PR has no effects since we are using
*policies, which means that all entries of the vector have the same value and the ordering does not matter.This PR is based on #26146.All but the last commit in this PR will be dropped when #26146 has been merged.