Skip to content

Commit 50b9fc3

Browse files
committed
[ot] hw/opentitan: fix trace levels: not an error if try function fails
Signed-off-by: Emmanuel Blot <eblot@rivosinc.com>
1 parent e57d046 commit 50b9fc3

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

hw/opentitan/ot_edn.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -563,15 +563,15 @@ static void ot_edn_try_auto_instantiate(OtEDNState *s)
563563

564564
if (ot_fifo32_is_empty(&c->sw_cmd_fifo)) {
565565
/* instantiate command not yet loaded into the SW_CMD_REQ */
566-
xtrace_ot_edn_error(c->appid, "no SW cmd in FIFO");
566+
xtrace_ot_edn_xinfo(c->appid, "no SW cmd in FIFO", 0);
567567
return;
568568
}
569569

570570
uint32_t command = ot_fifo32_peek(&c->sw_cmd_fifo);
571571
uint32_t length = FIELD_EX32(command, OT_CSNRG_CMD, CLEN) + 1u;
572572
if (ot_fifo32_num_used(&c->sw_cmd_fifo) < length) {
573573
/* instantiate command not fully loaded into the SW_CMD_REQ */
574-
xtrace_ot_edn_error(c->appid, "SW cmd FIFO incomplete");
574+
xtrace_ot_edn_xinfo(c->appid, "SW cmd FIFO incomplete", 0);
575575
return;
576576
}
577577

hw/opentitan/trace-events

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,7 @@ ot_entropy_src_info(const char *msg) "%s"
100100
ot_entropy_src_init_ongoing(const char *state, int st) "entropy source still initializing in [%s:%u]"
101101
ot_entropy_src_io_read_out(unsigned int addr, const char * regname, uint64_t val, uint64_t pc) "addr=0x%02x (%s), val=0x%" PRIx64 ", pc=0x%" PRIx64
102102
ot_entropy_src_io_write(unsigned int addr, const char * regname, uint64_t val, uint64_t pc) "addr=0x%02x (%s), val=0x%" PRIx64 ", pc=0x%" PRIx64
103-
ot_entropy_src_is_fips_capable(bool en, bool es_route, bool es_type, bool rng_bit_en, bool res) "en:%u rt:%u tp:%u rb:%u => %u"
103+
ot_entropy_src_is_fips_capable(bool en, bool es_route, bool es_type, bool rng_bit_en, bool res) "en:%u rt:%u tp:%u !rb:%u => %u"
104104
ot_entropy_src_no_entropy(unsigned count) "only %u words available"
105105
ot_entropy_src_obs_fifo(unsigned level, unsigned thold) "level %u, threshold %u"
106106
ot_entropy_src_otp_conf(bool fw_read, bool fw_over) "fw_read %u, fw_over %u"

0 commit comments

Comments
 (0)