Skip to content

Commit 9dce595

Browse files
committed
[ot] hw/opentitan: ot_edn: delayed mode change is legit, not an error
Signed-off-by: Emmanuel Blot <eblot@rivosinc.com>
1 parent 621a91b commit 9dce595

File tree

2 files changed

+2
-3
lines changed

2 files changed

+2
-3
lines changed

hw/opentitan/ot_edn.c

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -997,9 +997,7 @@ static void ot_edn_handle_ctrl(OtEDNState *s, uint32_t val32)
997997
}
998998

999999
if (!ot_edn_update_mode(s)) {
1000-
qemu_log_mask(LOG_GUEST_ERROR,
1001-
"%s: %u: EDN in %s, write 0x%08x to CTRL is delayed\n",
1002-
__func__, c->appid, STATE_NAME(s->state), val32);
1000+
trace_ot_edn_delay_mode_change(c->appid, STATE_NAME(s->state), val32);
10031001
}
10041002
}
10051003

hw/opentitan/trace-events

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -140,6 +140,7 @@ ot_edn_change_state(unsigned appid, int line, const char *old, int nold, const c
140140
ot_edn_connect_endpoint(unsigned appid, unsigned epid) "a#%u:e#%u"
141141
ot_edn_csrng_ack(unsigned appid, const char *state, int level) "a#%u %s %d"
142142
ot_edn_ctrl_in_state(unsigned appid, const char *state, int nstate, bool en, bool boot, bool auto_, bool clr, bool dis) "a#%u [%s:%d] en:%u boot:%u auto:%u clr:%u dis:%u"
143+
ot_edn_delay_mode_change(unsigned appid, const char *state, uint32_t ctrl) "a#%u %s ctrl:0x%08x"
143144
ot_edn_dinfo(unsigned appid, const char *func, int line, const char *msg, uint32_t value) "a#%u %s:%d %s %u"
144145
ot_edn_enable(unsigned appid, const char *msg) "a#%u: %s"
145146
ot_edn_ep_fifo(unsigned appid, const char *msg, unsigned remwslot) "a#%u %s rem:%u"

0 commit comments

Comments
 (0)