ot_aes: fix IV and CTR issues (cherry-pick #98) #100
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luismarques
changed the base branch from
ot-darjeeling-9.1.0
to
dev/ot-earlgrey-1.0.0-updates
|
LGTM, but I think it would be nice to use |
luismarques
force-pushed
the
aes-iv-fixes
branch
from
107961e to
92bae0b
Compare
|
See #99 for build issues |
Signed-off-by: Emmanuel Blot <eblot@rivosinc.com> (cherry picked from commit d224436)
…rent IV value Signed-off-by: Emmanuel Blot <eblot@rivosinc.com> (cherry picked from commit 9185a7a)
OT HW assumes the IV register in CTR mode exposes the IV of the next iteration once a round has been completed, while libtomcrypt only updates the CTR value when a new round is triggered. Signed-off-by: Emmanuel Blot <eblot@rivosinc.com> (cherry picked from commit 5524365)
luismarques
force-pushed
the
aes-iv-fixes
branch
from
92bae0b to
ff32436
Compare
luismarques
merged commit e7b1731
into
lowRISC:dev/ot-earlgrey-1.0.0-updates
6 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a cherry-pick of PR #98, that fixes reading the IV registers and properly incrementing the IV values.
To make the OT
aes_test.ctest pass there is an additional fix required, to not clear (randomize) the IV register. I'll make a follow-up PR.