[ot] hw/opentitan: ot_aon_timer: Make wakeup timer 64 bits #109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexJones0
force-pushed
the
aon_timer_64b_wkup
branch
from
e0bca2c to
10d4825
Compare
rivos-eblot
requested changes
Jan 22, 2025
There was a problem hiding this comment.
LGTM, except the file header (lowRISC, 2025 ... 😄)
Adding @loiclefort who better knowns the timer implementation than I do.
AlexJones0
force-pushed
the
aon_timer_64b_wkup
branch
from
10d4825 to
609a103
Compare
rivos-eblot
reviewed
Jan 22, 2025
rivos-eblot
reviewed
Jan 22, 2025
rivos-eblot
reviewed
Jan 22, 2025
rivos-eblot
requested changes
Jan 22, 2025
AlexJones0
force-pushed
the
aon_timer_64b_wkup
branch
from
609a103 to
434372a
Compare
For earlgrey-1.0.0, OpenTitan's aon_timer has been updated so that it's wakeup timer is now a 64-bit counter rather than a 32-bit counter (whereas the watchdog timer remains 32-bit). This requires the implementation of register mapping changes with each wakeup count / threshold register now having a HI/LO counterpart. Signed-off-by: Alex Jones <alex.jones@lowrisc.org>
AlexJones0
force-pushed
the
aon_timer_64b_wkup
branch
from
434372a to
ef6cf9e
Compare
I believe I've addressed the implicit signed/unsigned casts now, but please do double check |
loiclefort
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For
earlgrey-1.0.0, OpenTitan's aon_timer has been updated so that it's wakeup timer is now a 64-bit counter rather than a 32-bit counter (whereas the watchdog timer remains 32-bit). This PR makes the necessary implementation changes to add this functionality, including fixes to the values of shifted registers.This changes has been tested to make the following tests (which were previously failing) pass:
aon_timer_irq_test, andpwrmgr_wdog_test(running with an icount shift oficount=7). All tests were built from master on OpenTitan.