Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for decoding using column names #17

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add support for decoding using column names #17

wants to merge 1 commit into from

Conversation

dvic
Copy link
Contributor

@dvic dvic commented Jan 30, 2025 •
edited
Loading

related to #15

@dvic
Copy link
Contributor Author

dvic commented Jan 30, 2025

@lpil the prepared statement stuff was a bit more work and I see now that #13 is there. So this PR just adds a new query function that returns the results as a list of dicts. That works for me for now!

lpil
lpil reviewed Feb 24, 2025
View reviewed changes
Copy link
Owner

@lpil lpil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I'm a bit confused, this doesn't seem to do what the issue asked for?

@dvic
Copy link
Contributor Author

dvic commented Feb 24, 2025

Sorry, I'm a bit confused, this doesn't seem to do what the issue asked for?

Yes, you're right, it does not, I'll keep the issue open. However, this PR does solve some of the issues in the projects I'm working on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpil lpil lpil left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dvic @lpil