Skip to content

HTML response may be too large/long to generate #211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
pipoprods opened this issue Feb 3, 2025 · 3 comments · May be fixed by #226
Open

HTML response may be too large/long to generate #211

pipoprods opened this issue Feb 3, 2025 · 3 comments · May be fixed by #226
Assignees
@davidcoutadeur
Labels
enhancement New feature or request
Milestone
0.7

Comments

@pipoprods
Copy link

When a page generates a LDAP query that returns a huge number of records, then all of them are processed on the backend to generate a HTML page containing all the results. Pagination is completely handled on the frontend side, hiding/showing elements corresponding to the page number.

There are drawbacks to this approach:

  • when the HTML page is too long to generate, the request may reach reverse-proxies timeout
  • the response may be very huge (measured >50MB)

The pagination system architecture should be reconsidered to only return current page of results and request the backend at each page change.
@coudot
Copy link
Member

coudot commented Feb 3, 2025

See also ltb-project/white-pages#1

davidcoutadeur pushed a commit that referenced this issue Feb 7, 2025
first test of server-side pagination (#211)
ff55e4e
@davidcoutadeur
Copy link

davidcoutadeur commented Feb 11, 2025 •
edited
Loading

Some thoughts:

  • naïve approach: each time a search is requested, read every entry in the LDAP directory. This request can be slow (~5s for 5000 entries returned)
  • store the results in the user session (php session). advantage: when another user add or modify an entry while a first one is doing a paginated search, the one doing the search keeps having a coherent view of the results
  • store the result in a global cache (shared between users). Drawbacks: deal with the synchronization issues between cache and directory

@coudot coudot added the enhancement New feature or request label Feb 13, 2025
@coudot coudot added this to the Backlog milestone Feb 13, 2025
@coudot
Copy link
Member

coudot commented Feb 13, 2025

Another related issue: #207

davidcoutadeur pushed a commit that referenced this issue Apr 18, 2025
first test of server-side pagination (#211)
e604fe0
davidcoutadeur pushed a commit that referenced this issue Apr 18, 2025
add a rendering function for data in datatables (#211)
e9fee87
@davidcoutadeur davidcoutadeur self-assigned this Apr 18, 2025
@davidcoutadeur davidcoutadeur modified the milestones: Backlog, 0.7 Apr 18, 2025
@davidcoutadeur davidcoutadeur linked a pull request Apr 18, 2025 that will close this issue
Draft
davidcoutadeur pushed a commit that referenced this issue Apr 22, 2025
add js rendering functions (#211)
5728dd5
davidcoutadeur pushed a commit that referenced this issue Apr 30, 2025
add DN link type renderer (#211)
6e5fa30
davidcoutadeur pushed a commit that referenced this issue May 13, 2025
add mail, tel, and bool js renderer (#211)
e309922
davidcoutadeur pushed a commit that referenced this issue May 14, 2025
add code for js rendering of date functions (#211)
a347876
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davidcoutadeur davidcoutadeur

Labels
enhancement New feature or request
Projects
None yet
Milestone
0.7
Development

Successfully merging a pull request may close this issue.

211 pagination ltb-project/service-desk
3 participants
@coudot @davidcoutadeur @pipoprods