From 709bd20b49221c34cd58bb341a4d6bb3b10842c8 Mon Sep 17 00:00:00 2001
From: Filippo Gentile <filippogentile@disroot.org>
Date: Thu, 1 Feb 2024 18:14:29 +0100
Subject: [PATCH] FancyMenu: fix favorites in config file (#2020)

---
 plugin-fancymenu/lxqtfancymenu.cpp | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/plugin-fancymenu/lxqtfancymenu.cpp b/plugin-fancymenu/lxqtfancymenu.cpp
index 940eee8ff..c99f57c67 100644
--- a/plugin-fancymenu/lxqtfancymenu.cpp
+++ b/plugin-fancymenu/lxqtfancymenu.cpp
@@ -270,6 +270,8 @@ void LXQtFancyMenu::saveFavorites()
     const QStringList fileList = mWindow->favorites();
 
     QList<QMap<QString, QVariant> > list;
+    list.reserve(fileList.size());
+
     for(const QString& file : fileList)
     {
         QMap<QString, QVariant> item;
@@ -277,6 +279,9 @@ void LXQtFancyMenu::saveFavorites()
         list.append(item);
     }
 
+    // HACK: force Qt to clear old array and rewrite it
+    // Otherwise it would leave garbage values inside it.
+    settings()->remove(QStringLiteral("favorites"));
     settings()->setArray(QStringLiteral("favorites"), list);
 }