Skip to content

generalise PDFs in SigmaVar #301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ewanwm opened this issue Jan 21, 2025 · 1 comment
Open

generalise PDFs in SigmaVar #301

ewanwm opened this issue Jan 21, 2025 · 1 comment
Labels
Enhancement New feature or request no-issue-activity

Comments

@ewanwm
Copy link
Contributor

ewanwm commented Jan 21, 2025

In samplePDFBase we assume that getPDF returns TH1, which is nice and general

virtual TH1* getPDF(const int Selection){ (void) Selection; throw MaCh3Exception(__FILE__ , __LINE__ , "Not implemented");}
virtual inline TH1* getPDFMode(const int Selection, const int Mode) {

but then in sigma variations it is limited to only TH2Poly

std::unique_ptr<TH2Poly> currSamp(static_cast<TH2Poly*>(samples[ivs]->getPDF(k)->Clone()));

shouldn't be too difficult to make this more general since, just need to add some runtime checks on the num of dimensions and variables of the sample to the sigma var app and set titles etc. accordingly

@ewanwm ewanwm added the Enhancement New feature or request label Jan 21, 2025
Copy link

Stale issue message

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request no-issue-activity
Projects
None yet
Development

No branches or pull requests

1 participant