Skip to content

More Flexible Binning #461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
luketpickering opened this issue May 16, 2025 · 2 comments
Open

More Flexible Binning #461

luketpickering opened this issue May 16, 2025 · 2 comments
Labels
Enhancement New feature or request

Comments

@luketpickering
Copy link
Contributor

luketpickering commented May 16, 2025

DUNE analysis needs 2+ dimensional binning

ND280 analysis needs 2D arbitrary rectangular binning (TH2Poly-like)

Drop other constraints below:

I've implemented hyper-rectangular NDim binning in a minimally intrusive way (MaCh3 Core just sees a 1D axis in 'global bin number'). However, the current implementation works as a product of 1D axes and so cannot solve the ND280 problem. I have implementations for an arbitrary hyper-rectangular version, but didn't commit to implementing it yet as it wasn't needed for our DUNE use case (but might be in the future).

Apparently @KSkwarczynski is also working on a separate new binning technique, Add details/discussion here and lets discuss new binnings!

@luketpickering luketpickering added the Enhancement New feature or request label May 16, 2025
@EdAtkin
Copy link
Contributor

EdAtkin commented May 16, 2025

Personally I would b happy for us to drop the TH2Poly support and move to hyper-rectangular binning. Whilst the TH2Poly has been interesting to study for T2K ND280 I think the overhead it has added, in terms of supporting what is quite an annoying ROOT class, is not worth it.

I will also say that this makes the bin migration much easier to support in any dimension (rather than just the x axis at the moment).

It also should mean that we can loop over global bin number rather than X-bins and Y-bins because it's trivial to calculate the x, y, z (etc.) bin number if we have each 1D axis defined somewhere. This should lead to a small speed increase in the event reweighting.

@KSkwarczynski
Copy link
Member

Apparently @KSkwarczynski is also working on a separate new binning technique, Add details/discussion here and lets discuss new binnings!

I am not working on this right now just cherry picked some features for Abi so she can use 1.5.0

I think as long as we can do non-uniform bin edges I am happy in abandoning TH2Poly.
Even though I conceptually love idea of having banana, cat etc. binning that TH2Poly support, it caused me much more issues than worth.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants