chore: 미사용 통계성 기능 제거

maeil-mail · Feb 25, 2025 · bcd2b28 · bcd2b28
1 parent e4f8673
commit bcd2b28
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 36 deletions.
diff --git a/maeil-mail/src/main/java/maeilmail/statistics/StatisticsApi.java b/maeil-mail/src/main/java/maeilmail/statistics/StatisticsApi.java
@@ -1,5 +1,6 @@
 package maeilmail.statistics;
 
+import java.time.LocalDate;
 import lombok.RequiredArgsConstructor;
 import org.springframework.http.ResponseEntity;
 import org.springframework.web.bind.annotation.GetMapping;
@@ -19,8 +20,8 @@ public ResponseEntity<SubscribeReport> getDailySubscribeReport() {
     }
 
     @GetMapping("/statistics/subscribe-question")
-    public ResponseEntity<EventReport> getDailySubscribeQuestionReport() {
-        EventReport report = statisticsService.generateDailySubscribeQuestionReport();
+    public ResponseEntity<DailySendReport> getDailySubscribeQuestionReport() {
+        DailySendReport report = statisticsService.generateDailySendReport(LocalDate.now());
 
         return ResponseEntity.ok(report);
     }

diff --git a/maeil-mail/src/main/java/maeilmail/statistics/StatisticsService.java b/maeil-mail/src/main/java/maeilmail/statistics/StatisticsService.java
@@ -9,8 +9,6 @@
 import lombok.RequiredArgsConstructor;
 import maeilmail.bulksend.schedule.SendWeeklyQuestionScheduler;
 import maeilmail.subscribe.command.domain.SubscribeFrequency;
-import maeilmail.subscribe.command.domain.SubscribeQuestion;
-import maeilmail.subscribe.command.domain.SubscribeQuestionRepository;
 import maeilmail.subscribe.command.domain.SubscribeRepository;
 import maeilsupport.DateUtils;
 import org.springframework.stereotype.Service;
@@ -22,23 +20,8 @@
 public class StatisticsService {
 
     private final SubscribeRepository subscribeRepository;
-    private final SubscribeQuestionRepository subscribeQuestionRepository;
-    private final EventAggregator eventAggregator;
     private final StatisticsDao statisticsDao;
 
-    /***
-     * 금일 발송 질문 건수
-     */
-    // TODO : 사용 클라이언트 코드 존재하지 않음, 추후 삭제 예정
-    public EventReport generateDailySubscribeQuestionReport() {
-        LocalDate today = LocalDate.now();
-        LocalDateTime startOfDay = today.atStartOfDay();
-        LocalDateTime endOfDay = today.plusDays(1).atStartOfDay().minusNanos(1);
-        List<SubscribeQuestion> result = subscribeQuestionRepository.findSubscribeQuestionByCreatedAtBetween(startOfDay, endOfDay);
-
-        return eventAggregator.aggregate(result);
-    }
-
     /**
      * 일간 전송 통계
      */

diff --git a/maeil-mail/src/test/java/maeilmail/statistics/StatisticsServiceTest.java b/maeil-mail/src/test/java/maeilmail/statistics/StatisticsServiceTest.java
@@ -12,7 +12,6 @@
 import maeilmail.subscribe.command.domain.Subscribe;
 import maeilmail.subscribe.command.domain.SubscribeFrequency;
 import maeilmail.subscribe.command.domain.SubscribeQuestion;
-import maeilmail.subscribe.command.domain.SubscribeQuestionRepository;
 import maeilmail.subscribe.command.domain.SubscribeRepository;
 import maeilmail.support.IntegrationTestSupport;
 import maeilmail.support.data.SendReportCountingCase;
@@ -28,9 +27,6 @@ class StatisticsServiceTest extends IntegrationTestSupport {
     @Autowired
     private SubscribeRepository subscribeRepository;
 
-    @Autowired
-    private SubscribeQuestionRepository subscribeQuestionRepository;
-
     @Autowired
     private QuestionRepository questionRepository;
 
@@ -77,19 +73,6 @@ void countNewSubscribersOnSpecificDate2() {
         assertThat(distinctEmailsCount).isEqualTo(0);
     }
 
-    @Test
-    @DisplayName("주어진 타입의 오늘 발생한 메일 이벤트의 성공과 실패를 집계한다.")
-    void generateDailySubscribeQuestionReport() {
-        subscribeQuestionRepository.save(createSubscribeQuestion(true));
-        subscribeQuestionRepository.save(createSubscribeQuestion(true));
-        subscribeQuestionRepository.save(createSubscribeQuestion(false));
-
-        EventReport eventReport = statisticsService.generateDailySubscribeQuestionReport();
-
-        assertThat(eventReport.success()).isEqualTo(2);
-        assertThat(eventReport.fail()).isEqualTo(1);
-    }
-
     @Test
     @DisplayName("주어진 일자의 전송 통계를 생성한다.")
     void generateDailySendReport() {