Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] Creating a way to customize the order of "Temperatures" panel in a similar way to the dashboard #2150

Open
AERVAQR3GZ opened this issue Feb 16, 2025 · 7 comments
Labels
💡 Type: FR Requests a new feature ❔ User Input Further information is requested

Comments

@AERVAQR3GZ
Copy link

Requested feature:

Simple idea: A menu like that of the Dashboard, that can be used to reorder, select and deselect certain temperatures.

This would be nice because it just keeps everything so ordered and in place, and is just a nice QoL touch.

Image

Image

Solves the following problem:

It fixes and removes redundant temperatures and irregular orders, such as can be seen in the above attached photo, where there are 3 sensors telling the chamber temp, and the heater bed rear sensor (used to equilibrate the temperature so the whole bed is adequately warmed, not just the center) is neither above nor below the Heater Bed Center Temperature Sensor)), can be removed or reordered, cleaning up the temperature section of the dashboard.

Additional information:

Feel free to let me know if you need anymore information.

@AERVAQR3GZ AERVAQR3GZ added the 💡 Type: FR Requests a new feature label Feb 16, 2025
@meteyou
Copy link
Member

meteyou commented Feb 16, 2025

Just use a _ as first char of the name to hide objects.

@AERVAQR3GZ
Copy link
Author

to hide objects.
Why thank you! But at the same time, it doesn't solve the reordering of the temperatures, so its not a full fix.

@meteyou
Copy link
Member

meteyou commented Feb 16, 2025

this was just a hint to "fix" one of your issues. i dont close this FR or something else. i also dont think i will implement hide, because all klipper objects can be hide with the _ and this is quite normale. thats why we dont "hide" something in the gui.

the emoji with "thumbs down" is a little bit rude. i can also just close your FR and dont implement it, if you think this is a better way?

@meteyou meteyou added the ❔ User Input Further information is requested label Feb 16, 2025
@meteyou
Copy link
Member

meteyou commented Feb 16, 2025

and just another question. why do you use multiple times the same sensor in your printer config? (that should be the first reason, why you have multiple objects with the same value here)

@AERVAQR3GZ
Copy link
Author

multiple times the same sensor in your printer config?
Honestly that is a good question. Ill take a look. Would it be in the printer.cfg file?

@AERVAQR3GZ
Copy link
Author

why do you use multiple times the same sensor in your printer config?

Honestly, I don't know. The main person who has been working on the printer is my Father, and I am not that accustomed to the printer's code. I've had a look in the config, and from what I can tell, it is required to link the exhaust fans to the bed fans? Which turn on whenever the chamber heater turns on, but that might not be it.

I tried to underscore what I thought was the variable that showed up in the dashboard, but it threw an error. I tried it with the chamber heater to see if it would work, but it said: "Unknown heater 'chamber_heater'". I think it might mean that I would have to change all of the variables with the name 'chamber_heater' to '_chamber_heater', but he has modded and coded the printer so much I am not even sure what the name of the sensors to hide are, let alone how to replace them all.

Also, to address your question (which I now realize I did awfully little of), I think they are all separate sensors. All of the temperatures are off by a decimal of a degree at almost all times, so I think they are all unique sensors, its just that its got extra sensors from mods.

If there are any ways that you know of to do this, I am all ears.

Many thanks

@meteyou
Copy link
Member

meteyou commented Feb 19, 2025

I tried to underscore what I thought was the variable that showed up in the dashboard, but it threw an error. I tried it with the chamber heater to see if it would work, but it said: "Unknown heater 'chamber_heater'". I think it might mean that I would have to change all of the variables with the name 'chamber_heater' to '_chamber_heater', but he has modded and coded the printer so much I am not even sure what the name of the sensors to hide are, let alone how to replace them all.

Yes, thats right. if this name is also used in some macros or in other config sections, you have to rename it everywhere.

Also, to address your question (which I now realize I did awfully little of), I think they are all separate sensors. All of the temperatures are off by a decimal of a degree at almost all times, so I think they are all unique sensors, its just that its got extra sensors from mods.

ah ok. i just saw 2 sensors are identical in your (exhaust & chamber), thats why i ask.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💡 Type: FR Requests a new feature ❔ User Input Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants