-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Tim's Airport Challenge #2500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
timbo-graham
wants to merge
3
commits into
makersacademy:main
Choose a base branch
from
timbo-graham:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Tim's Airport Challenge #2500
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,65 @@ | ||
require 'airport' | ||
require 'plane' | ||
|
||
class Airport | ||
|
||
attr_accessor :hanger | ||
|
||
def initialize(capacity = 5) | ||
|
||
@capacity = capacity | ||
@hanger = [] | ||
|
||
end | ||
|
||
def random_weather | ||
|
||
rand(10) | ||
|
||
end | ||
|
||
def can_take_off? | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I like how you made two separate methods for 'can_take_off?' and 'can_land?' you've made it easy to understand. |
||
|
||
if random_weather <= 3 | ||
fail "It's blowin' a gale out there, hold your horses" | ||
end | ||
|
||
end | ||
|
||
def take_off(plane) | ||
|
||
if @hanger.include?(plane) | ||
@hanger.delete(plane) | ||
else | ||
fail "That plane is not available for take off" | ||
end | ||
|
||
end | ||
|
||
def can_land? | ||
|
||
if random_weather <= 3 | ||
fail "It's blowin' a gale out there, hold your horses" | ||
end | ||
|
||
end | ||
|
||
def land(plane) | ||
|
||
if full? | ||
fail "The airport is full, please wait" | ||
elsif @hanger.include?(plane) | ||
fail "That plane has already landed" | ||
else | ||
@hanger << plane | ||
end | ||
|
||
end | ||
|
||
def full? | ||
|
||
@hanger.count >= @capacity | ||
|
||
end | ||
|
||
end |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
require 'airport' | ||
require 'plane' | ||
|
||
class Plane | ||
|
||
end |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,77 @@ | ||
require 'airport' | ||
require 'plane' | ||
|
||
describe Airport do | ||
|
||
it "lands plane when instructed" do | ||
|
||
plane = Plane.new | ||
subject.land(plane) | ||
expect(subject.hanger).to include plane | ||
|
||
end | ||
|
||
it "takes off from airport when instructed, and is no longer at the airport" do | ||
|
||
plane = Plane.new | ||
subject.hanger << plane | ||
subject.take_off(plane) | ||
expect(subject.hanger).not_to include plane | ||
|
||
end | ||
|
||
it "checks whether the airport hanger is full" do | ||
|
||
plane = Plane.new | ||
5.times { subject.hanger << plane } | ||
expect(subject.full?).to eq true | ||
|
||
end | ||
|
||
it "prevents landing when the aiport hanger is full" do | ||
|
||
plane = Plane.new | ||
5.times { subject.hanger << plane } | ||
expect { subject.land(plane) }.to raise_error("The airport is full, please wait") | ||
|
||
end | ||
|
||
it "prevents take off when weather is stormy" do | ||
|
||
plane = Plane.new | ||
allow(subject).to receive(:random_weather) { 3 } | ||
expect { subject.can_take_off? }.to raise_error("It's blowin' a gale out there, hold your horses") | ||
|
||
end | ||
|
||
it "prevents landing when weather is stormy" do | ||
|
||
plane = Plane.new | ||
allow(subject).to receive(:random_weather) { 3 } | ||
expect { subject.can_land? }.to raise_error("It's blowin' a gale out there, hold your horses") | ||
|
||
end | ||
|
||
it "random_weather should generate a random number between 1 and 10" do | ||
|
||
expect(subject.random_weather).to be < 11 | ||
expect(subject.random_weather).to be > 0 | ||
|
||
end | ||
|
||
it "attempting to take off a plane that isn't present should raise an error" do | ||
|
||
plane = Plane.new | ||
expect { subject.take_off(plane) }.to raise_error("That plane is not available for take off") | ||
|
||
end | ||
|
||
it "attempting to land a plane that has already landed should raise an error" do | ||
|
||
plane = Plane.new | ||
subject.hanger << plane | ||
expect { subject.land(plane) }.to raise_error("That plane has already landed") | ||
|
||
end | ||
|
||
end |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
require 'airport' | ||
require 'plane' | ||
|
||
describe Plane do | ||
|
||
it "Instances of Plane should be true" do | ||
|
||
plane = Plane.new | ||
expect(plane).to eq plane | ||
|
||
end | ||
|
||
end |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could add a Constant variable for capacity to reduce use of magic numbers.