Skip to content

Commit 16c55ac

Browse files
authored
fix(test): Eliminate Race Between LivenessScope Closing and GC (deephaven#6197)
Fixes deephaven#3545.
1 parent 3066b7f commit 16c55ac

File tree

1 file changed

+9
-8
lines changed

1 file changed

+9
-8
lines changed

engine/table/src/test/java/io/deephaven/engine/table/impl/QueryTableAjTest.java

+9-8
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
//
44
package io.deephaven.engine.table.impl;
55

6+
import io.deephaven.engine.liveness.LivenessScope;
67
import io.deephaven.engine.table.impl.AsOfJoinMatchFactory.AsOfJoinResult;
78
import io.deephaven.base.clock.Clock;
89
import io.deephaven.base.testing.BaseArrayTestCase;
@@ -661,31 +662,31 @@ public void testAjRandomLeftIncrementalRightStatic() {
661662
for (int leftSize = 10; leftSize <= maxLeftSize; leftSize *= leftFactor) {
662663
for (int rightSize = 10; rightSize <= maxRightSize; rightSize *= rightFactor) {
663664
System.out.println("Seed=" + seed + ", leftSize=" + leftSize + ", rightSize=" + rightSize);
664-
try (final SafeCloseable ignored = LivenessScopeStack.open()) {
665+
try (final SafeCloseable ignored = LivenessScopeStack.open(new LivenessScope(true), true)) {
665666
testAjRandomIncremental(base.leftStep, seed, leftSize, rightSize, true, false, false, false);
666667
}
667-
try (final SafeCloseable ignored = LivenessScopeStack.open()) {
668+
try (final SafeCloseable ignored = LivenessScopeStack.open(new LivenessScope(true), true)) {
668669
testAjRandomIncremental(base.leftStep, seed, leftSize, rightSize, true, false, true, false);
669670
}
670-
try (final SafeCloseable ignored = LivenessScopeStack.open()) {
671+
try (final SafeCloseable ignored = LivenessScopeStack.open(new LivenessScope(true), true)) {
671672
testAjRandomIncremental(base.leftStep, seed, leftSize, rightSize, true, false, false, true);
672673
}
673-
try (final SafeCloseable ignored = LivenessScopeStack.open()) {
674+
try (final SafeCloseable ignored = LivenessScopeStack.open(new LivenessScope(true), true)) {
674675
testAjRandomIncremental(base.leftStep, seed, leftSize, rightSize, true, false, true, true);
675676
}
676-
try (final SafeCloseable ignored = LivenessScopeStack.open()) {
677+
try (final SafeCloseable ignored = LivenessScopeStack.open(new LivenessScope(true), true)) {
677678
testAjRandomIncremental(base.leftStepShift, seed, leftSize, rightSize, true, false, false,
678679
false);
679680
}
680-
try (final SafeCloseable ignored = LivenessScopeStack.open()) {
681+
try (final SafeCloseable ignored = LivenessScopeStack.open(new LivenessScope(true), true)) {
681682
testAjRandomIncremental(base.leftStepShift, seed, leftSize, rightSize, true, false, true,
682683
false);
683684
}
684-
try (final SafeCloseable ignored = LivenessScopeStack.open()) {
685+
try (final SafeCloseable ignored = LivenessScopeStack.open(new LivenessScope(true), true)) {
685686
testAjRandomIncremental(base.leftStepShift, seed, leftSize, rightSize, true, false, false,
686687
true);
687688
}
688-
try (final SafeCloseable ignored = LivenessScopeStack.open()) {
689+
try (final SafeCloseable ignored = LivenessScopeStack.open(new LivenessScope(true), true)) {
689690
testAjRandomIncremental(base.leftStepShift, seed, leftSize, rightSize, true, false, true, true);
690691
}
691692
}

0 commit comments

Comments
 (0)