Skip to content

Commit 7b47794

Browse files
authored
revert: RST_STREAM(cancel) fix for gRPC, this seems to be breaking JS gRPC client (deephaven#6420)
This reverts commit 6ada0cb. See deephaven#6401 See deephaven#6400 See deephaven#5996
1 parent 52af771 commit 7b47794

File tree

1 file changed

+1
-7
lines changed

1 file changed

+1
-7
lines changed

grpc-java/grpc-servlet-jakarta/src/main/java/io/grpc/servlet/jakarta/AsyncServletOutputStreamWriter.java

+1-7
Original file line numberDiff line numberDiff line change
@@ -121,15 +121,9 @@ public boolean isFinestEnabled() {
121121
transportState.runOnTransportThread(
122122
() -> {
123123
transportState.complete();
124-
// asyncContext.complete();
124+
asyncContext.complete();
125125
log.fine("call completed");
126126
});
127-
// Jetty specific fix: When AsyncContext.complete() is called, Jetty sends a RST_STREAM with
128-
// "cancel" error to the client, while other containers send "no error" in this case. Calling
129-
// close() instead on the output stream still sends the RST_STREAM, but with "no error". Note
130-
// that this does the opposite in at least Tomcat, so we're not going to upstream this change.
131-
// See https://github.com/deephaven/deephaven-core/issues/6400
132-
outputStream.close();
133127
};
134128
this.isReady = () -> outputStream.isReady();
135129
}

0 commit comments

Comments
 (0)