Skip to content

Commit cf4a0fd

Browse files
authored
Add a local copy of build-dependencies.sh for cpp-client, and add a PR check that is kept up to date. (deephaven#5072)
* Add a local copy of build-dependencies.sh for cpp-client, and add a PR check that is kept up to date. * Remove unnecessary tmp file.
1 parent 3be488b commit cf4a0fd

File tree

4 files changed

+862
-20
lines changed

4 files changed

+862
-20
lines changed

cpp-client/README.md

+4-20
Original file line numberDiff line numberDiff line change
@@ -34,26 +34,11 @@ on them anymore so we do notguarantee they are current for those platforms.
3434

3535
6. Build and install dependencies for Deephaven C++ client.
3636

37-
Get the `build-dependencies.sh` script from Deephaven's base images repository.
38-
39-
***Note you need the right version of `build-dependencies.sh` matching
40-
your sources***.
41-
42-
The link in the paragraph that follows points to a specific
43-
version that works with the code this README.md files accompanies;
44-
if you are reading a different version of the README.md compared
45-
to the source version you will be trying to compile, go back
46-
to the right `README.md` now.
47-
48-
Download `build-dependencies.sh` directly from
49-
https://github.com/deephaven/deephaven-base-images/raw/0f2c39f142140601b92d69a8fe8ee0c49b76ec7b/cpp-client/build-dependencies.sh
50-
51-
(this script is also used from our automated tools, to generate a docker image to
52-
support tests runs; that's why it lives in a separate repo).
53-
The script downloads, builds and installs the dependent libraries
37+
The `build-dependencies.sh` script in this directory downloads,
38+
builds and installs the dependent libraries
5439
(Protobuf, re2, gflags, absl, flatbuffers, c-ares, zlib, gRPC, and Arrow).
5540
Decide on a directory for the dependencies to live (eg, "$HOME/dhcpp").
56-
Create that directory and save the script there.
41+
Create that directory and copy the script there.
5742

5843
The three main build types of a standard cmake build are supported,
5944
`Release`, `Debug` and `RelWithDebInfo`. By default. `build-dependencies.sh`
@@ -73,9 +58,8 @@ on them anymore so we do notguarantee they are current for those platforms.
7358
export DHCPP=$HOME/dhcpp
7459
# If the directory already exists from a previous attempt, ensure is clean/empty
7560
mkdir -p $DHCPP
61+
cp build-dependencies.sh $DHCPP
7662
cd $DHCPP
77-
wget https://github.com/deephaven/deephaven-base-images/raw/0f2c39f142140601b92d69a8fe8ee0c49b76ec7b/cpp-client/build-dependencies.sh
78-
chmod +x ./build-dependencies.sh
7963
# Maybe edit build-dependencies.sh to reflect choices of build tools and build target, if you
8064
# want anything different than defaults; defaults are tested to work,
8165
# any deviation from defaults may require changing other files later.

0 commit comments

Comments
 (0)