fix(cppclient): Remove extension from dhclient and dhcore for cross-platform compatibility (deephaven#5706)

kosak · web-flow · commit ff09e2939346 · 2024-07-02T04:42:24.000Z
Windows expects .dll and Linux expects .so, but the machinery behind
LibraryImport seems to know to do the right thing.
diff --git a/csharp/client/DeephavenClient/Interop/InteropSupport.cs b/csharp/client/DeephavenClient/Interop/InteropSupport.cs
@@ -6,8 +6,8 @@
 namespace Deephaven.DeephavenClient.Interop;
 
 internal class LibraryPaths {
-  internal const string Dhcore = "dhcore.dll";
-  internal const string Dhclient = "dhclient.dll";
+  internal const string Dhcore = "dhcore";
+  internal const string Dhclient = "dhclient";
 }
 
 /// <summary>

Original file line number	Diff line number	Diff line change
`@@ -6,8 +6,8 @@`
`6`	`6`	`namespace Deephaven.DeephavenClient.Interop;`
`7`	`7`
`8`	`8`	`internal class LibraryPaths {`
`9`		`- internal const string Dhcore = "dhcore.dll";`
`10`		`- internal const string Dhclient = "dhclient.dll";`
	`9`	`+ internal const string Dhcore = "dhcore";`
	`10`	`+ internal const string Dhclient = "dhclient";`
`11`	`11`	`}`
`12`	`12`
`13`	`13`	`/// <summary>`