Skip to content

Commit d11045c

Browse files
committed
Revert "make required keys mandatory (logicalclocks#319)"
This reverts commit f44cbca.
1 parent 5785abd commit d11045c

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

python/hsfs/core/vector_server.py

+3-1
Original file line numberDiff line numberDiff line change
@@ -556,7 +556,8 @@ def assemble_feature_vector(
556556
"1. There is no match in the given entry."
557557
" Please check if the entry exists in the online feature store"
558558
" or provide the feature as passed_feature. "
559-
f"2. Required entries [{', '.join(self.required_serving_keys)}] are not provided."
559+
f"2. Required entries [{', '.join(self.required_serving_keys)}] or "
560+
f"[{', '.join(set(sk.feature_name for sk in self._serving_keys))}] are not provided."
560561
)
561562

562563
if len(self.return_feature_value_handlers) > 0:
@@ -1475,6 +1476,7 @@ def valid_serving_keys(self):
14751476
if not self._valid_serving_keys or len(self._valid_serving_keys) == 0:
14761477
self._valid_serving_keys = set(
14771478
[sk.required_serving_key for sk in self.serving_keys]
1479+
+ [sk.feature_name for sk in self.serving_keys]
14781480
)
14791481
return self._valid_serving_keys
14801482

0 commit comments

Comments
 (0)