add option for commercial license, plus translations

app/helpers/models_helper.rb

@@ -28,13 +28,18 @@ def license_select_options(selected: nil)
         CC-PDDC
         CC0-1.0
         MIT
+        LicenseRef-Commercial
       ].map { |id|
         [
-          Spdx.licenses[id]["name"] + " (#{id})",
+          t_license(id),
           id
         ]
       },
       selected: selected
     )
   end
+
+  def t_license(license)
+    t("licenses.%{id}" % {id: license.delete(".")}, default: license)
+  end
 end

app/views/models/show.html.erb

@@ -48,7 +48,9 @@
         <tr>
           <td><%= icon "card-heading", "License" %></td>
           <td>
-            <%= link_to @model.license, Spdx.licenses[@model.license]["reference"] %>
+            <%= Spdx.licenses[@model.license]&.fetch("reference") ?
+              link_to(t_license(@model.license), Spdx.licenses[@model.license]["reference"]) :
+              t_license(@model.license) %>
           </td>
         </tr>
       <% end %>

config/i18n-tasks.yml

@@ -121,6 +121,7 @@ ignore_unused:
 - 'activerecord.attributes.*'
 - 'activerecord.models.*'
 - 'problems.categories.*'
+- 'licenses.*'
 # - '{devise,kaminari,will_paginate}.*'
 # - 'simple_form.{yes,no}'
 # - 'simple_form.{placeholders,hints,labels}.*'

config/locales/en.yml

@@ -43,6 +43,17 @@ en:
   libraries:
     general:
       new: New Library
+  licenses:
+    CC-BY-40: Creative Commons Attrbution
+    CC-BY-NC-40: Creative Commons Attribution NonCommercial
+    CC-BY-NC-ND-40: Creative Commons Attribution NonCommercial NoDerivatives
+    CC-BY-NC-SA-40: Creative Commons Attribution NonCommercial ShareAlike
+    CC-BY-ND-40: Creative Commons Attribution NoDerivatives
+    CC-BY-SA-40: Creative Commons Attribution ShareAlike
+    CC-PDDC: Creative Commons Public Domain Declaration
+    CC0-10: Creative Commons Zero
+    LicenseRef-Commercial: Commercial; private use only
+    MIT: MIT
   model_files:
     show:
       duplicate_card:

spec/models/model_spec.rb

@@ -42,6 +42,12 @@
       m = build(:model, license: "Made up license")
       expect(m).not_to be_valid
     end
+
+    it "allows LicenseRef-Commercial to represent private use only" do
+      # See https://scancode-licensedb.aboutcode.org/commercial-license.html
+      m = build(:model, license: "LicenseRef-Commercial")
+      expect(m).to be_valid
+    end
   end
 
   it "strips leading and trailing separators from paths" do