Fix #145 Scotland not working for PublicHolidays(year)

Author: martinjw

src/PublicHoliday/UKBankHoliday.cs

@@ -327,7 +327,7 @@ public override IDictionary<DateTime, string> PublicHolidayNames(int year)
         /// <returns></returns>
         public override IList<DateTime> PublicHolidays(int year)
         {
-            return BankHolidays(year);
+            return PublicHolidayNames(year).Keys.ToList();
         }
 
         /// <summary>

tests/PublicHolidayTests/TestUKBankHoliday.cs

@@ -363,6 +363,16 @@ public void TestScotland2022()
             }
         }
 
+
+        [TestMethod]
+        public void TestScotland2025()
+        {
+            //according to https://www.mygov.scot/scotland-bank-holidays official dates:
+            var ukHols = new UKBankHoliday { UkCountry = UKBankHoliday.UkCountries.Scotland };
+            var hols = ukHols.PublicHolidays(2025);
+            Assert.AreEqual(9, hols.Count, "There are 9 holidays");
+        }
+
         [TestMethod]
         public void TestNortherIreland2021()
         {