-
Notifications
You must be signed in to change notification settings - Fork 72
[WIP] Slim version of TaskDoc for production #1232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
tsmathis
wants to merge
23
commits into
main
Choose a base branch
from
mp-prod-taskdoc
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clean up class def to reflect current utililty
+ utility decorators for customizing arrow type introspection behavior
… to help with arrow roundtriping
…th arrow + add optimade to optional deps for testing - needed due to walking emmet to import all pydantic models
Will do! Yeah the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will be considered experimental until performance + compatibility with builder/api client can be tested
@esoteric-ephemera, check if the field split I made here makes sense. Can worry about model validators and a parsing method later after I've tested the basic schema works for the build pipelines + api
Based this branch off your
alpha_id
branch for the updatedtask_id
typing.Also makes more sense for the top level
output
field to be the calc output right?