-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Supporting passing in weights #10
Comments
I don't quite understand how would that work. Implemented formulas for covariance shrinkage assume normal covariance and a specific shrinkage target. Wouldn't using weighted covariance lead to wrong shrinkage coefficients? |
Hmmm, good point. I guess the R corpcor just lets you pass in the weights with a data matrix rather than precomputed values. |
StatsBase.jl has its own approach to weights and it looks nicer. I think it would be good to have a similar design here. |
Support for weights from StatsBase.jl in simple estimators (see #10 f…
Supporting weights, following the StatsBase API of |
Yes, it would be very useful, but I still don't know if it's even possible to have generic implementation for all types of weights. Frequency weights should be relatively easy to support though. What kind of weights do you need? |
I believe |
Unfortunately, I don't know how to modify Ledoit-Wolf to make it work with |
My colleague tells me it is not possible (or at least the proof in the LW paper breaks down when weights are added) ...but i've not done the working myself nor seen a paper on it. |
NOTE: a potential work around could be to collect a weighted sampling first and then estimate the covariance from that. |
It might be nice to support a lower level
fit
andtransform
API on top of justcov
. This would allow folks to pass in an existing covariance matrix that they'd like to apply an estimation method to (e.g., a weighted covariance).The text was updated successfully, but these errors were encountered: