Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nicknames with asterisks (*) appear as undefined at Matrix (CTCPs from undefined are broken too) / ROLEPLAY are broken #1422

Closed
Mikaela opened this issue Jul 18, 2021 · 1 comment

Comments

@Mikaela
Copy link
Contributor

Mikaela commented Jul 18, 2021

Describe the bug

Said in the title, practically #712 and #1411, except ROLEPLAY is borderline deprecated while not going to be removed from codebase.

To Reproduce
Steps to reproduce the behavior:

  1. Go to room with roleplay enabled (mode +E) on a server with ROLEYPLAY enabled
  2. Send NPC #channel whoever whatever or NPCA #channel whoever does whatever
  3. Observe nicks who should be whoever being unknown instead

Expected behavior

The nickname appears properly

Edit: adding keyword Ergo IRCd

@emersonveenstra
Copy link
Contributor

This is also matrix-org/node-irc#81, but there's more of a chance that a lot of stuff could blow up because the mxid spec says "For example, "*" is used as a wildcard in some APIs (notably the filter API), so it cannot be a legal user ID character." synapse will accept it, but we might need to encode the asterisks somehow

@Mikaela Mikaela closed this as completed Jul 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants