Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Messages from IRC user sharing nickname with Matrix user don't come through at all #1438

Open
Mikaela opened this issue Jul 29, 2021 · 3 comments
Labels
S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems.

Comments

@Mikaela
Copy link
Contributor

Mikaela commented Jul 29, 2021

Describe the bug

When there is a Matrix user and IRC user by the same nickname, messages from the IRC user don't come through. This is a common scenario with Ergo IRCd which includes integrated bouncer and generally forces all connections to use the same nickname.

To Reproduce

  1. Register on Ergo IRCd e.g. https://liberta.casa/gamja/ using NickServ as usual
  2. Connect to the same IRCd using Matrix logging in (e.g. #irc_#libcasa.info:liberta.casa)
  3. Both connections should now use the same name. Send messages from them
  4. See that Matrix has no messages sent from IRC.

Expected behavior

Messages send from IRC are shown on Matrix. I know the appservice cannot pretend to be the MXID, but it could join the IRC ghost into the room (in my case @irc_Aminda:liberta.casa) to show the messages or maybe the appservice itself could show the messages (like Heisenbridge: "You said: ...)

Screenshots

image

image

Additional context

@Mikaela
Copy link
Contributor Author

Mikaela commented Jul 29, 2021

Attachment: IRCCloud & Heisenbridge on irc.ergo.chat:

image

  • the less privileged here is part of the gecos and means that this account is not my primary one and thus if it got compromised through a third party service, it couldn't be used to do so nasty things as the main account which actually owns channels and has access to channels not belonging to me could.

image

@Half-Shot
Copy link
Contributor

When there is a Matrix user and IRC user by the same nickname, messages from the IRC user don't come through.

As it stands, the bridge does not support multiple users sharing the same nickname. We treat nicknames as unique, and the bridge will not bridge anything from a user it perceives to own.

I'd imagine the solution to this would be #72, but since that issue requires a total overhaul of the inner workings, we've not got to it yet.

@Mikaela
Copy link
Contributor Author

Mikaela commented Aug 18, 2021

I don't understand #72 considering the hostmask would be identical for both Matrix and IRC user if they logged in as the same IRC account.

@jaller94 jaller94 added T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems. S-Major Severely degrades major functionality or product features, with no satisfactory workaround labels May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems.
Projects
None yet
Development

No branches or pull requests

3 participants