Duplicate messages matrix-side (due to distributed IRCds) #27

matrixbot · 2016-04-29T10:30:44Z

Created by @ matthew:matrix.org.

e.g. roblabla on https://vector.im/beta/#/room/!cURbafjkfsMDVwdRDQ:matrix.org/$146192559593207XoTMY:matrix.org and half-shot a few days earlier

kegsay · 2016-06-02T08:50:00Z

The permalink says the commit sha: c3f8dbf6b5b5f33bebae09c2e92866e140e4601b

kegsay · 2016-06-02T09:12:23Z

Probably related: https://matrix.org/jira/browse/BOTS-142

kegsay · 2016-07-22T15:22:15Z

This SHA is for Synapse, not the IRC bridge and is therefore useless.

kegsay · 2016-07-22T15:29:52Z

Tried to repro this on v0.3.1 and I cannot. Used the demo federation with user IDs:

@fewd:localhost:8481
@fewd:localhost:8482

I surmise the title of this bug is wrong, or that particular issue has already been fixed. BOTS-142 still seems valid though, so clobbering this issue with that.

kegsay · 2016-07-22T15:33:25Z

This is the important bit:

2015-11-16 17:28:39 INFO:irc-client <M-intelfx@irc.freenode.net#bion5hs2eo848> (@intelfx:matrix.org) Connecting to IRC server irc.freenode.net as M-intelfx (user=intelfxmat)
2015-11-16 17:28:41 DEBUG:client-pool Connected with nick 'M-intelfx1' instead of desired nick 'M-intelfx'
2015-11-22 03:43:38 ERROR:client-connection M-intelfx@irc.freenode.net: {"command":"ERROR","rawCommand":"ERROR","commandType":"normal","args":["Closing Link: gateway/shell/matrix.org/x-ufiwesbeopqhxsaf (Ping timeout: 244 seconds)"]}
2015-11-22 03:43:38 INFO:client-connection disconnect()ing M-intelfx@irc.freenode.net - raw_error
2015-11-22 03:43:38 DEBUG:client-pool onClientDisconnected: <bion5hs2eo848> Reconnecting M-intelfx1@irc.freenode.net in 10000ms
2015-11-22 03:43:48 INFO:irc-client <M-intelfx@irc.freenode.net#kakx3kvehj44c> (@intelfx:matrix.org) Connecting to IRC server irc.freenode.net as M-intelfx (user=intelfxmat)
2015-11-22 03:45:46 ERROR:client-connection M-intelfx@irc.freenode.net still not connected after 30000ms. Killing connection.
2015-11-22 03:45:46 INFO:client-connection disconnect()ing M-intelfx@irc.freenode.net - timeout
2015-11-22 03:46:24 DEBUG:irc-client <M-intelfx@irc.freenode.net#kakx3kvehj44c> (@intelfx:matrix.org) connected!
2015-11-22 03:46:24 DEBUG:irc-client <M-intelfx@irc.freenode.net#kakx3kvehj44c> (@intelfx:matrix.org) _keepAlive; Restarting 432000s idle timeout
2015-11-22 03:46:24 INFO:client-pool <kakx3kvehj44c> Reconnected M-intelfx@irc.freenode.net
2015-11-22 03:55:27 INFO:irc-client <M-intelfx@irc.freenode.net#kakx3kvehj44c> (@intelfx:matrix.org) NICK: Nick changed from 'M-intelfx' to '20WACI3YG'.

Netsplit and the single nick => Client mapping is wrong.

kegsay · 2016-07-22T15:37:22Z

This relates heavily to #72 - We might as well do that rather than faff with Nick => [Client] mappings (instead it'll be Username => Client which the bridge can ensure are unique 😄 )

kegsay · 2016-07-22T15:38:32Z

Punting this to the next release as #72 is effectively a blocker and I don't feel like doing that right now.

kegsay · 2017-04-13T15:43:12Z

This reared its ugly head again today, though the cause isn't a netsplit. If you connect with the same nick to 2 freenode servers at the same time, the IRCds don't handshake first before accepting the connection, so there's a brief period where both servers accept the connection for the same nick. This then gets corrected less than a second later, but by this point it's too late because it has clobbered the entry in the ClientPool. The entire sequence is:

// connect to one server, which accepts the proposed nick
clientPool["Alice"] = clientAlice
// connect at the same time to a different server, which also accepts the same nick. This clobbers `clientAlice` irreparably. 
clientPool["Alice"] = clientAlice2
// bridge gets rename
clientPool["425FE25"] = clientPool["Alice"]
clientPool["Alice"] = null;

But we keep another map of user_id -> client as well, so M->I is not affected by this. This means messages to IRC go out correctly, but means we don't recognise the nick when it comes back to us, so we send it on to Matrix again.

kegsay · 2017-04-13T15:44:04Z

Changed title because this is not netsplit specific anymore.

copumpkin · 2017-11-13T21:01:25Z

@kegsay I'm seeing some duplicate messages on Matrix's IRC bridge to freenode in the ##nix-darwin channel. Not sure if that's a different cause or related to this one. I think the whole thing started with a netsplit a couple of weeks ago and hasn't fixed itself since.

simoniz0r · 2018-04-05T12:26:17Z

I just managed to do this yesterday by using NickServ from freenode to IDENTIFY and then REGAIN my nick.

Perflyst · 2019-07-28T11:17:06Z

Seems like I currently have this bug in any room which is bridged to Freenode.

Half-Shot · 2019-07-28T12:20:44Z

For reference, we are tracking this bug at the moment. The likely short term fix next week will be a bridge restart coupled with some related bug fixes. I suspect the very least we can do is some kind of debugAPI to refresh broken rooms.

In the shorter term, you are free to ban *[m] users from your rooms as it won't interrupt the bridge.

Mikaela · 2019-07-29T09:32:40Z

In the shorter term, you are free to ban *[m] users from your rooms as it won't interrupt the bridge.

I think this comment is easy to interpret as mode +b *[m]!*@* which bans all Matrix users using the default nick from the channels. I guess you meant that Matrix-side moderators should op their IRC ghosts and then ban the *[m] users on Matrix-side.

Half-Shot · 2019-07-29T10:06:35Z

In the shorter term, you are free to ban *[m] users from your rooms as it won't interrupt the bridge.

I think this comment is easy to interpret as mode +b *[m]!*@* which bans all Matrix users using the default nick from the channels. I guess you meant that Matrix-side moderators should op their IRC ghosts and then ban the *[m] users on Matrix-side.

Yes, I should be clear here. Please do NOT ban the matrix users from the IRC side -- that will break things. Ban @freenode_.*[m]:matrix.org users if they start echoing as it won't affect the bridge.

Although hopefully for the time being this is a moot point, as hopefully the restart just now fixed stuff.

Mikaela · 2021-07-10T14:07:08Z

I have reproduced this on Ergo IRCd which doesn't even support server linking.

join #libcasa:liberta.casa
say something to get invited to bridge admin room
!storepass Mikaela-@libertacasamatrix:password
say something
see how everything I say is duplicated.

Reconnecting to network...
Connecting to the IRC network 'irc.liberta.casa' as mikaela{m}...
Your connection to the IRC network 'irc.liberta.casa' has been lost. 
SASL authentication successful: You are now logged in as Mikaela-
You've been connected to the IRC network 'irc.liberta.casa' as mikaela{m}.
<me> !nick Mikaela-
The nickname Mikaela- is taken on irc.liberta.casa. Please pick a different nick.

BridgeVersion: 0.27.0

On Matrix I am @mikaela:liberta.casa and my ghost who gets repeated is @irc_Mikaela-:liberta.casa. On IRC only messages from Mikaela- are visible.

I think this is matrix-appservice-irc not handling the integrated bouncer of Ergo which is enforcing my nickname into being my accountname (Mikaela-).

See also: https://github.com/ergochat/ergo/blob/v2.7.0/docs/USERGUIDE.md#how-ergo-is-different

In case you try to reproduce this on liberta.casa, #371 or something similar is hitting it and you cannot contact @lunatic:liberta.casa unless you are on the same homeserver.

Network IRCv3 capabilities in case they are of any help: account-notify account-tag away-notify batch cap-notify chghost draft/channel-rename draft/chathistory draft/event-playback draft/languages=1,en draft/multiline=max-bytes=4096,max-lines=100 draft/register=before-connect draft/relaymsg=/ echo-message extended-join invite-notify labeled-response message-tags multi-prefix oragono.io/nope sasl=PLAIN,EXTERNAL server-time setname userhost-in-names znc.in/playback znc.in/self-message

Mikaela · 2021-07-10T14:35:50Z

I don't know whether this is a new issue or #502 (comment), but additionally when I join the 13 missing rooms by hand, in the end I am in 14 rooms as one has duplicated and I cannot see anything sent from IRC while IRC can read me in some cases.

Possibly yet another issue is that some of the rooms have +i or +k where I am allowed to join right in due to having CS AMODE +h and being already in so not needing to enter key, but the matrixbot (lunatic) doesn't and thus cannot.

Mikaela · 2021-07-12T09:01:39Z

Update on reproducing on Ergo (#27 (comment)): I can !reconnect as much as I want and consistently reproduce this issue on every attempt.

Reconnecting to network...
Connecting to the IRC network 'irc.liberta.casa' as mikaela{m}...
Your connection to the IRC network 'irc.liberta.casa' has been lost. 
SASL authentication successful: You are now logged in as Mikaela-
You've been connected to the IRC network 'irc.liberta.casa' as mikaela{m}.

Maybe Ergo is a good IRCd to test against for fixing this bug in general if others don't allow reproducing this consistently?

slingamn · 2021-07-27T12:38:09Z

The diagnosis on matrix-org/node-irc#74 looks correct to me. The issue is this: in general, an IRC server can assign a client a nickname that differs from the one the client requested with NICK. The client is expected to deduce this from the first parameter of the 001 RPL_WELCOME numeric.

To simplify reproducing the issue, I created an account on testnet.ergo.chat, account name nickchangetest, password _UqRdsxHQmbxWbUwq11APQ. Here's a sample transcript:

C: CAP REQ sasl
S: :testnet.ergo.chat CAP * ACK sasl
C: AUTHENTICATE PLAIN
S: AUTHENTICATE +
C: AUTHENTICATE bmlja2NoYW5nZXRlc3QAbmlja2NoYW5nZXRlc3QAX1VxUmRzeEhRbWJ4V2JVd3ExMUFQUQ==
S: :testnet.ergo.chat 900 * * nickchangetest :You are now logged in as nickchangetest
S: :testnet.ergo.chat 903 * :Authentication successful
C: NICK nickchangetest_
C: USER u s e r
C: CAP END
S: :testnet.ergo.chat 001 nickchangetest :Welcome to the ErgoTestnet IRC Network nickchangetest
S: :testnet.ergo.chat 002 nickchangetest :Your host is testnet.ergo.chat, running version ergo-2.7.0
S: :testnet.ergo.chat 003 nickchangetest :This server was created Tue, 08 Jun 2021 05:08:05 UTC

Mikaela · 2021-07-29T07:35:27Z

This issue is fixed in 0.29.0-rc2, thank you.

It does introduce a new issue I am opening soon.

kegsay added bug needs-investigation labels Jun 2, 2016

kegsay self-assigned this Jul 14, 2016

kegsay changed the title ~~IRC bridge starts looping from IRC->Matrix if user speaks with same user ID from different servers~~ Duplicate messages matrix-side Jul 22, 2016

kegsay changed the title ~~Duplicate messages matrix-side~~ Duplicate messages matrix-side (due to netsplits) Jul 22, 2016

kegsay removed the needs-investigation label Jul 22, 2016

kegsay removed their assignment Jul 22, 2016

kegsay changed the title ~~Duplicate messages matrix-side (due to netsplits)~~ Duplicate messages matrix-side (due to distributed IRCds) Apr 13, 2017

Mikaela mentioned this issue Jun 11, 2017

Allow configuring bridged user display name format vijfhoek/telematrix#33

Closed

Mikaela mentioned this issue Oct 20, 2017

Option to prohibit bridges of bridges to the IRC network. #510

Closed

Half-Shot added p1 needs-investigation labels Jul 28, 2019

Half-Shot mentioned this issue Jul 4, 2020

#stripe is seeing two messages for each user #1073

Closed

Mikaela mentioned this issue Jul 10, 2021

Implement /sajoin and /sapart commands #502

Open

Mikaela mentioned this issue Jul 10, 2021

My libera nick parrots back what I say on matrix channel #1393

Open

Mikaela mentioned this issue Jul 18, 2021

matrix-appservice-irc demands !username to be unique while IRC has no such restriction #1421

Open

This comment has been minimized.

Sign in to view

Mikaela mentioned this issue Jul 27, 2021

Possible race condition with truncated nicks matrix-org/node-irc#74

Closed

Mikaela mentioned this issue Jul 29, 2021

Messages from IRC user sharing nickname with Matrix user don't come through at all #1438

Open

justinbot added T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems. and removed bug labels May 13, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Duplicate messages matrix-side (due to distributed IRCds) #27

Duplicate messages matrix-side (due to distributed IRCds) #27

matrixbot commented Apr 29, 2016

kegsay commented Jun 2, 2016

kegsay commented Jun 2, 2016

kegsay commented Jul 22, 2016

kegsay commented Jul 22, 2016

kegsay commented Jul 22, 2016

kegsay commented Jul 22, 2016

kegsay commented Jul 22, 2016

kegsay commented Apr 13, 2017

kegsay commented Apr 13, 2017

copumpkin commented Nov 13, 2017

simoniz0r commented Apr 5, 2018

Perflyst commented Jul 28, 2019

Half-Shot commented Jul 28, 2019

Mikaela commented Jul 29, 2019

Half-Shot commented Jul 29, 2019

Mikaela commented Jul 10, 2021

Mikaela commented Jul 10, 2021

Mikaela commented Jul 12, 2021

This comment has been minimized.

slingamn commented Jul 27, 2021

Mikaela commented Jul 29, 2021

Duplicate messages matrix-side (due to distributed IRCds) #27

Duplicate messages matrix-side (due to distributed IRCds) #27

Comments

matrixbot commented Apr 29, 2016

kegsay commented Jun 2, 2016

kegsay commented Jun 2, 2016

kegsay commented Jul 22, 2016

kegsay commented Jul 22, 2016

kegsay commented Jul 22, 2016

kegsay commented Jul 22, 2016

kegsay commented Jul 22, 2016

kegsay commented Apr 13, 2017

kegsay commented Apr 13, 2017

copumpkin commented Nov 13, 2017

simoniz0r commented Apr 5, 2018

Perflyst commented Jul 28, 2019

Half-Shot commented Jul 28, 2019

Mikaela commented Jul 29, 2019

Half-Shot commented Jul 29, 2019

Mikaela commented Jul 10, 2021

Mikaela commented Jul 10, 2021

Mikaela commented Jul 12, 2021

This comment has been minimized.

slingamn commented Jul 27, 2021

Mikaela commented Jul 29, 2021