Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix idempotency issue around token refresh #4730

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented Feb 27, 2025

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@t3chguy t3chguy self-assigned this Feb 27, 2025
@t3chguy t3chguy marked this pull request as ready for review February 27, 2025 10:33
@t3chguy t3chguy requested review from a team as code owners February 27, 2025 10:33
@t3chguy t3chguy requested review from dbkr and florianduros February 27, 2025 10:33
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Copy link
Member

@dbkr dbkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Decorator seems little magic perhaps vs the more obvious wrapper function, but happy enough to go with it.

@t3chguy
Copy link
Member Author

t3chguy commented Feb 27, 2025

Decorator seems little magic perhaps vs the more obvious wrapper function, but happy enough to go with it.

they're supported out of the box in TS and on their way into ECMA so time to start seeing them.

We could/should ditch babel in the js-sdk given we rely on apps to bundle the matrix-js-sdk anyway and then we won't need the babel decorator proposal stuff

@t3chguy t3chguy added this pull request to the merge queue Feb 27, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Element chat keeps logging out
2 participants