Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Commit

Permalink
Playwright: Enable more tests in editing-messages.spec.ts (#12001)
Browse files Browse the repository at this point in the history
* Enable skipped test in `editing-messages.spec.ts`

* Enable 2 more tests in `editing-messages.spec.ts`

* Fix `A room where all threaded edits are read is still read after restart` integ test

* Fix `A room where all threaded edits are read is still read after restart` integ test

* WIP fix `A room where all threaded edits are read is still read after restart `

* WIP fix `A room where all threaded edits are read is still read after restart `
  • Loading branch information
florianduros authored Dec 7, 2023
1 parent df11b90 commit d6d3585
Showing 1 changed file with 9 additions and 10 deletions.
19 changes: 9 additions & 10 deletions playwright/e2e/read-receipts/editing-messages.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -287,20 +287,20 @@ test.describe("Read receipts", () => {
// Then is it still read
await util.assertRead(room2);
});
// XXX: Failing since migration to Playwright
test.skip("A room where all threaded edits are read is still read after restart", async ({
test("A room where all threaded edits are read is still read after restart", async ({
roomAlpha: room1,
roomBeta: room2,
util,
msg,
}) => {
await util.goTo(room1);
await util.receiveMessages(room2, ["Msg1", msg.threadedOff("Msg1", "Resp1")]);
await util.assertUnread(room2, 2);
await util.receiveMessages(room2, [msg.editOf("Resp1", "Edit1")]);
await util.assertUnread(room2, 2);

await util.goTo(room2);
await util.receiveMessages(room2, [
"Msg1",
msg.threadedOff("Msg1", "Resp1"),
msg.editOf("Resp1", "Edit1"),
]);
await util.assertUnread(room2, 1);

await util.openThread("Msg1");
await util.assertRead(room2);
await util.goTo(room1); // Make sure we are looking at room1 after reload
Expand All @@ -309,8 +309,7 @@ test.describe("Read receipts", () => {
await util.saveAndReload();
await util.assertRead(room2);
});
// XXX: fails because the room becomes unread after restart
test.skip("A room where all threaded edits are marked as read is still read after restart", async ({
test("A room where all threaded edits are marked as read is still read after restart", async ({
roomAlpha: room1,
roomBeta: room2,
util,
Expand Down

0 comments on commit d6d3585

Please sign in to comment.