Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Playwright: Enable more tests in editing-messages.spec.ts #12001

Merged
merged 7 commits into from
Dec 7, 2023
Merged

Playwright: Enable more tests in editing-messages.spec.ts #12001

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
ec578a8
Enable skipped test in `editing-messages.spec.ts`
florianduros Dec 5, 2023
a703186
Enable 2 more tests in `editing-messages.spec.ts`
florianduros Dec 5, 2023
7bca426
Fix `A room where all threaded edits are read is still read after res…
florianduros Dec 6, 2023
9b64d98
Merge branch 'develop' into florianduros/unread/enable-skipped-editin…
florianduros Dec 6, 2023
b0144fc
Fix `A room where all threaded edits are read is still read after res…
florianduros Dec 6, 2023
8e5d7fc
WIP fix `A room where all threaded edits are read is still read after…
florianduros Dec 6, 2023
5da0732
WIP fix `A room where all threaded edits are read is still read after…
florianduros Dec 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 9 additions & 10 deletions playwright/e2e/read-receipts/editing-messages.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -287,20 +287,20 @@ test.describe("Read receipts", () => {
// Then is it still read
await util.assertRead(room2);
});
// XXX: Failing since migration to Playwright
test.skip("A room where all threaded edits are read is still read after restart", async ({
test("A room where all threaded edits are read is still read after restart", async ({
roomAlpha: room1,
roomBeta: room2,
util,
msg,
}) => {
await util.goTo(room1);
await util.receiveMessages(room2, ["Msg1", msg.threadedOff("Msg1", "Resp1")]);
await util.assertUnread(room2, 2);
await util.receiveMessages(room2, [msg.editOf("Resp1", "Edit1")]);
await util.assertUnread(room2, 2);

await util.goTo(room2);
await util.receiveMessages(room2, [
"Msg1",
msg.threadedOff("Msg1", "Resp1"),
msg.editOf("Resp1", "Edit1"),
]);
await util.assertUnread(room2, 1);

await util.openThread("Msg1");
await util.assertRead(room2);
await util.goTo(room1); // Make sure we are looking at room1 after reload
Expand All @@ -309,8 +309,7 @@ test.describe("Read receipts", () => {
await util.saveAndReload();
await util.assertRead(room2);
});
// XXX: fails because the room becomes unread after restart
test.skip("A room where all threaded edits are marked as read is still read after restart", async ({
test("A room where all threaded edits are marked as read is still read after restart", async ({
roomAlpha: room1,
roomBeta: room2,
util,
Expand Down