Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Playwright: Enable skipped tests in redactions.spec.ts #12023

Merged
merged 1 commit into from
Dec 11, 2023
Merged

Playwright: Enable skipped tests in redactions.spec.ts #12023

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 12 additions & 24 deletions playwright/e2e/read-receipts/redactions.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,8 +206,7 @@ test.describe("Read receipts", () => {
// Then the room is back to being read
await util.assertRead(room2);
});
// XXX: fails because it flakes saying the room is unread when it should be read
test.skip("Redacting all unread messages makes the room read after restart", async ({
test("Redacting all unread messages makes the room read after restart", async ({
roomAlpha: room1,
roomBeta: room2,
util,
Expand Down Expand Up @@ -277,8 +276,7 @@ test.describe("Read receipts", () => {
// Then the room is still read
await util.assertStillRead(room2);
});
// XXX: fails because flakes showing 2 unread instead of 1
test.skip("A reply to a redacted message makes the room unread", async ({
test("A reply to a redacted message makes the room unread", async ({
roomAlpha: room1,
roomBeta: room2,
util,
Expand Down Expand Up @@ -368,8 +366,7 @@ test.describe("Read receipts", () => {
await util.goTo(room2);
await util.assertReadThread("Root");
});
// XXX: fails because it flakes (on CI only)
test.skip("Reading an unread thread after a redaction of the latest message makes it read", async ({
test("Reading an unread thread after a redaction of the latest message makes it read", async ({
roomAlpha: room1,
roomBeta: room2,
util,
Expand Down Expand Up @@ -399,8 +396,7 @@ test.describe("Read receipts", () => {
await util.goTo(room2);
await util.assertReadThread("Root");
});
// XXX: fails because the unread count is still 1 when it should be 0
test.skip("Reading an unread thread after a redaction of the latest message makes it read after restart", async ({
test("Reading an unread thread after a redaction of the latest message makes it read after restart", async ({
roomAlpha: room1,
roomBeta: room2,
util,
Expand Down Expand Up @@ -432,8 +428,7 @@ test.describe("Read receipts", () => {
// Then the room is still read
await util.assertRead(room2);
});
// XXX: fails because it flakes (on CI only)
test.skip("Reading an unread thread after a redaction of an older message makes it read", async ({
test("Reading an unread thread after a redaction of an older message makes it read", async ({
roomAlpha: room1,
roomBeta: room2,
util,
Expand Down Expand Up @@ -463,8 +458,7 @@ test.describe("Read receipts", () => {
await util.goTo(room2);
await util.assertReadThread("Root");
});
// XXX: fails because it flakes (on CI only)
test.skip("Marking an unread thread as read after a redaction makes it read", async ({
test("Marking an unread thread as read after a redaction makes it read", async ({
roomAlpha: room1,
roomBeta: room2,
util,
Expand All @@ -490,8 +484,7 @@ test.describe("Read receipts", () => {
await util.goTo(room2);
await util.assertReadThread("Root");
});
// XXX: fails because the room has an unread dot after I marked it as read
test.skip("Sending and redacting a message after marking the thread as read leaves it read", async ({
test("Sending and redacting a message after marking the thread as read leaves it read", async ({
roomAlpha: room1,
roomBeta: room2,
util,
Expand All @@ -518,8 +511,7 @@ test.describe("Read receipts", () => {
await util.goTo(room2);
await util.assertReadThread("Root");
});
// XXX: fails because the room has an unread dot after I marked it as read
test.skip("Redacting a message after marking the thread as read leaves it read", async ({
test("Redacting a message after marking the thread as read leaves it read", async ({
roomAlpha: room1,
roomBeta: room2,
util,
Expand Down Expand Up @@ -573,8 +565,7 @@ test.describe("Read receipts", () => {
// Then the room is unread
await util.assertStillRead(room2);
});
// XXX: fails because the room is still unread after opening the thread (initially)
test.skip("Editing a redacted message leaves the thread read", async ({
test("Editing a redacted message leaves the thread read", async ({
roomAlpha: room1,
roomBeta: room2,
util,
Expand Down Expand Up @@ -602,8 +593,7 @@ test.describe("Read receipts", () => {
// Then the room is unread
await util.assertStillRead(room2);
});
// XXX: failed because flakes: https://github.com/vector-im/element-web/issues/26594
test.skip("Reading a thread after a reaction to a redacted message marks the thread as read", async ({
test("Reading a thread after a reaction to a redacted message marks the thread as read", async ({
roomAlpha: room1,
roomBeta: room2,
util,
Expand All @@ -629,8 +619,7 @@ test.describe("Read receipts", () => {
await util.assertRead(room2);
await util.assertReadThread("Root");
});
// XXX: fails because the unread count stays at 1 instead of zero
test.skip("Reading a thread containing a redacted, edited message marks the thread as read", async ({
test("Reading a thread containing a redacted, edited message marks the thread as read", async ({
roomAlpha: room1,
roomBeta: room2,
util,
Expand Down Expand Up @@ -681,8 +670,7 @@ test.describe("Read receipts", () => {
await util.assertRead(room2);
await util.assertReadThread("Root");
});
// XXX: fails because flakes saying 2 unread instead of 1
test.skip("Reading a thread root when its only message has been redacted leaves the room read", async ({
test("Reading a thread root when its only message has been redacted leaves the room read", async ({
roomAlpha: room1,
roomBeta: room2,
util,
Expand Down