Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Adding description for Clear Cache and Reload Button in Settings #5811

Closed
wants to merge 3 commits into from

Conversation

tawfiek
Copy link
Contributor

@tawfiek tawfiek commented Mar 26, 2021

Fixes element-hq/element-web#5800
Screenshot from 2021-03-26 18-54-23


This PR currently has none of the required changelog labels.

A reviewer can add one of: T-Deprecation, T-Enhancement, T-Defect, T-Task to indicate what type of change this is, or add Type: [enhancement/defect/task] to the description and I'll add them for you.

- in setting modal Help&About tab
@tawfiek
Copy link
Contributor Author

tawfiek commented Mar 26, 2021

I can provide an Arabic translation for the new added description, should I do this into the same PR ?!

@t3chguy
Copy link
Member

t3chguy commented Mar 26, 2021

should I do this into the same PR

No as it'll cause conflicts in Weblate, all translations must be done from Weblate only

@SimonBrandner
Copy link
Contributor

I can provide Arabic translation for the new added description, should I do this into the same PR ?!

No, the translations are done through Webplate

@t3chguy t3chguy requested a review from a team March 26, 2021 16:57
@tawfiek
Copy link
Contributor Author

tawfiek commented Mar 26, 2021

so should I delete what I added for en_US ?!

@SimonBrandner
Copy link
Contributor

SimonBrandner commented Mar 26, 2021

so should I delete what I added for en_US ?!

That should have been autogenerated using yarn i18n

Since you didn't do that you have globe-with-meridians-i18n failing

@niquewoodhouse
Copy link
Contributor

Design review

This is much easier to understand for me than the current version. Just the copy would ideally be slightly clearer.

  • New copy
    • Clear cache and reload Element
    • This will delete all cached data, reload Element and automatically log you in. No key backups will be deleted.

Is it called key backups or backup keys in Element? Is it more useful to just say generally 'no security information will be deleted?

@t3chguy
Copy link
Member

t3chguy commented Jul 12, 2021

and automatically log you in.

This is misleading, as logging you in would make you expect the New sign in toasts on other devices which will not happen here. Your device ID (unique to each login) will not change

@ShadowJonathan
Copy link

ShadowJonathan commented Jul 12, 2021

"No key backups will be deleted" is hard to understand for those not in the know, I'd say "Your end-to-end-encryption keys will not be affected" would work better

@niquewoodhouse
Copy link
Contributor

"No key backups will be deleted" is hard to understand for those not in the know, I'd say "Your end-to-end-encryption keys will not be affected" would work better

That's definitely easier for me to understand (and I'm not in the know) but do we refer to them as end-to-end-encryption keys anywhere else? I just wonder if you'd then be looking for that exact phrase in other areas of Element, and so it further complicates all the names we have/use. Eg "I'm looking for my e2e keys" Would rather use the exact same phrases or something so generic it doesn't sound potentially specific e.g:

"Your encryption settings will not be deleted or affected in anyway." But I don't know much about this area of Element.

@MadLittleMods
Copy link
Contributor

@tawfiek Please update the PR with the copy suggestions above. This one looks almost good to go 😊

Bundling all of the points above, perhaps:

  • Clear cache and reload Element
  • This will delete all cached data and reload Element (you will still be signed in). Your encryption settings and keys will not be deleted or affected in anyway.

@tawfiek
Copy link
Contributor Author

tawfiek commented Dec 11, 2021

Yes, this much cleaner and very obvious, I'll add this to my schedule for the next week.
I think that I'll need to go through all the building and configuration stuff to run Matrix, it's been a long time since I contributed here.
But it'll be my pleasure to finish what I started with you guys 😇

@ShadowJonathan
Copy link

No login required

I just noticed this, maybe it should be "No re-login required" or something along the lines?

Maybe "You'll stay logged in" is better.

@andybalaam
Copy link
Member

@tawfiek any chance you could update this as requested? Thanks!

@andybalaam
Copy link
Member

Feel free to pick this up when you get to it, but I'll mark it as draft for now so that it drops off our radar since it's not ready.

@andybalaam andybalaam marked this pull request as draft September 15, 2022 15:35
@andybalaam
Copy link
Member

Please mark it as non-draft if you get this ready for another review. Thanks!

@richvdh richvdh temporarily deployed to Cypress November 30, 2022 13:09 Inactive
@richvdh richvdh temporarily deployed to Cypress November 30, 2022 13:09 Inactive
@richvdh richvdh temporarily deployed to Cypress November 30, 2022 13:09 Inactive
@richvdh richvdh temporarily deployed to Cypress November 30, 2022 13:09 Inactive
@tawfiek tawfiek reopened this Nov 30, 2022
@tawfiek
Copy link
Contributor Author

tawfiek commented Nov 30, 2022

Hello, I need small assistance to get back into the community,
How to join Element channels?

@dbkr
Copy link
Member

dbkr commented Jul 29, 2024

It's been 2 years since we heard anything here I believe it's probably deprecated by new settings UI design, so I'm going to close this again. It's also in a rather broken state (github doesn't think there is a diff).

@dbkr dbkr closed this Jul 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clear cache and reload should probably explain what it actually does
9 participants