Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only one of sdpMLineIndex or sdpMid should be required in Candidate #1078

Closed
zecakeh opened this issue May 22, 2022 · 2 comments
Closed

Only one of sdpMLineIndex or sdpMid should be required in Candidate #1078

zecakeh opened this issue May 22, 2022 · 2 comments
Labels
spec-bug Something which is in the spec, but is wrong

Comments

@zecakeh
Copy link
Contributor

zecakeh commented May 22, 2022

Link to problem area: https://spec.matrix.org/v1.2/client-server-api/#mcallcandidates

Issue
According to the WebRTC spec, both sdpMid and sdpMLineIndex are nullable, but one of those two values must be set:

If both the sdpMid and sdpMLineIndex members of candidateInitDict are null, throw a TypeError. (source)

Currently in the spec they are both marked as required.

Expected behaviour
Both fields should be nullable, explaining that at least one of the two is required.

In practice, both the matrix-js-sdk and Element Android check that at least one of those is set, respecting the WebRTC spec, which makes this a spec bug rather than requiring an MSC.

@zecakeh zecakeh added the spec-bug Something which is in the spec, but is wrong label May 22, 2022
@zecakeh zecakeh changed the title Only one of sdpMLineIndex or sdpMid should be required in `Candidate Only one of sdpMLineIndex or sdpMid should be required in Candidate May 22, 2022
@richvdh
Copy link
Member

richvdh commented Apr 5, 2023

Still the case in https://spec.matrix.org/v1.6/client-server-api/#mcallcandidates.

@dbkr: can you confirm this?

@zecakeh
Copy link
Contributor Author

zecakeh commented Mar 8, 2024

Fixed with #1742.

@zecakeh zecakeh closed this as completed Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
spec-bug Something which is in the spec, but is wrong
Projects
None yet
Development

No branches or pull requests

2 participants