sas: clarify HKDF calculation uses base64-encoded keys #1719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sumner Evans <sumner@beeper.com>
sumnerevans
force-pushed
the
clarify-sas-hkdf
branch
from
be52526 to
9b78c49
Compare
dkasak
approved these changes
Feb 22, 2024
anoadragon453
approved these changes
Feb 26, 2024
28 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
name: sas: clarify HKDF calculation uses base64-encoded keys
about: The SAS HKDF calculation uses base64-encoded strings, not raw key bytes.
title: ''
labels: ''
assignees: ''
Signed-off-by: Sumner Evans sumner@beeper.com
Pull Request Checklist
Preview: https://pr1719--matrix-spec-previews.netlify.app