Update HTML templates to link to object definitions #1724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no need for full `{{/* ... */}}` comment markers here: simple `/*
... */` ones work fine.
... so that we have a chance to modify it first.
richvdh
force-pushed
the
rav/links_for_object_defs_2
branch
from
5662133 to
03f932b
Compare
richvdh
commented
Feb 14, 2024
Comment on lines
-145
to
-147
| {{/* | ||
| As far as I know we don't have something like Array.concat(), so add them one at a time | ||
| */}} |
There was a problem hiding this comment.
I removed this comment, since I found it misleading. We do have something like Array.concat -- it's called append, which does concatenate arrays if you pass an array as its parameter. However, it's not very useful here, because we want to call clean-object on each item before adding it to $all_objects.
uhoreg
approved these changes
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a series of commits which add hyperlinks to the definitions of subschemas. I'm hoping this might help with navigation for complex data structures like that returned by
/sync.Each of the commits, with the exception of "Link to HTML anchors, where they exist" has been tested to have no effect n the output. The "Link..." commit just adds
<href a="...">links where possible.Before:
After:
Preview: https://pr1724--matrix-spec-previews.netlify.app