Clarify that join rules must be in auth events for knock events #2063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since it is necessary for passing the authorization rules Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
|
It looks to be that way in Synapse: https://github.com/element-hq/synapse/blob/068e22b4b7c5d38064cf04353de36fbc1ead6ba9/synapse/event_auth.py#L1163. It should have been in the MSC (MSC2403), but I guess it got forgotten, as you say. |
richvdh
approved these changes
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since it is necessary for passing the authorization rules (step 4.7.1).
It must have been forgotten when knocking was introduced in v1.1.
Pull Request Checklist
Preview: https://pr2063--matrix-spec-previews.netlify.app