-
-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Describe behaviour when the topic
key is falsey in a m.room.topic
event.
#2068
base: main
Are you sure you want to change the base?
Conversation
…vent. We seem to have [updated this for m.room.name](matrix-org#1639) some years back but omitted it for topic.
topic
key is falsey in a m.room.topic e…topic
key is falsey in a m.room.topic event.
topic
key is falsey in a m.room.topic event.topic
key is falsey in a m.room.topic
event.
The room topic can also be set when creating a room using `/createRoom` with the `topic` key.' | ||
|
||
If a room has an `m.room.topic` event with an absent, null, or empty `topic` | ||
field, it should be treated the same as a room with no `m.room.topic` event. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While it's a great clarification in itself, it would be even greater to further clarify what happens when an event with an absent/null/empty topic
comes upon a previous event with non-falsey topic
. I guess the room topic should be reset to the as-if-no-topic state?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, I suppose I thought that was the implication as with the m.room.name
description => clients should use the latest state to render the room, and this description tells clients to assume the topic isn't set.
I'm struggling to find words that doesn't sound a bit repetitive?
be suitable for the room name. | ||
The room topic can also be set when creating a room using `/createRoom` with the `topic` key.' | ||
|
||
If a room has an `m.room.topic` event with an absent, null, or empty `topic` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So it should be noted, again as with m.room.name
, that Synapse doesn't allow a topic without a string topic key.
So this present behavior doesn't exist there, but I need to survey the other homeservers.
We seem to have updated this for m.room.name some years back but omitted it for topic.
Signed-off-by: Half-Shot signoff@half-shot.uk
Pull Request Checklist
Preview: https://pr2068--matrix-spec-previews.netlify.app