Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Describe behaviour when the topic key is falsey in a m.room.topic event. #2068

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Half-Shot
Copy link
Contributor

@Half-Shot Half-Shot commented Jan 31, 2025

We seem to have updated this for m.room.name some years back but omitted it for topic.

Signed-off-by: Half-Shot signoff@half-shot.uk

Pull Request Checklist

Preview: https://pr2068--matrix-spec-previews.netlify.app

…vent.

We seem to have [updated this for m.room.name](matrix-org#1639) some years back but omitted it for topic.
@Half-Shot Half-Shot requested a review from a team as a code owner January 31, 2025 11:21
@Half-Shot Half-Shot changed the title Describe behaviour when the topic key is falsey in a m.room.topic e… Describe behaviour when the topic key is falsey in a m.room.topic event. Jan 31, 2025
@Half-Shot Half-Shot changed the title Describe behaviour when the topic key is falsey in a m.room.topic event. Describe behaviour when the topic key is falsey in a m.room.topic event. Jan 31, 2025
The room topic can also be set when creating a room using `/createRoom` with the `topic` key.'

If a room has an `m.room.topic` event with an absent, null, or empty `topic`
field, it should be treated the same as a room with no `m.room.topic` event.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While it's a great clarification in itself, it would be even greater to further clarify what happens when an event with an absent/null/empty topic comes upon a previous event with non-falsey topic. I guess the room topic should be reset to the as-if-no-topic state?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, I suppose I thought that was the implication as with the m.room.name description => clients should use the latest state to render the room, and this description tells clients to assume the topic isn't set.

I'm struggling to find words that doesn't sound a bit repetitive?

be suitable for the room name.
The room topic can also be set when creating a room using `/createRoom` with the `topic` key.'

If a room has an `m.room.topic` event with an absent, null, or empty `topic`
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So it should be noted, again as with m.room.name, that Synapse doesn't allow a topic without a string topic key.

So this present behavior doesn't exist there, but I need to survey the other homeservers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants