Adjust margins in rendered endpoints #2081
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tables used `4 rem` which is more than the margin above a h2 title, which seems excessive. We change it to `2 rem` which matches the margin of code blocks and info boxes. We also remove the margin on the last item of a `.rendered-data` block because this is just wasted space. Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
Given that h2 titles are always preceded by an horizontal rule, we don't need a lot of space to separate them from the previous section. We also reduce the spacing when a h2 title is followed directly by a h3 title. Finally, we add a little spacing below both so that tables are less close to the title. Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It felt that there was a lot of wasted space in those because of the spacing between tables. There are 2 commits here:
Use consistent spacing between tables and code blocks:
Tables used
4 rembetween 2 tables which is more than the margin above ah2title, which seems excessive. We change it to2 remwhich matches the default margin of code blocks and info boxes. To make sure that this stays consistent we apply it to both tables and code blocks.I feel like we could probably reduce it further to
1.5 rem. That would require to change the default margins for code blocks and info boxes for consistency.We also remove the margin if it's the last item of a
.rendered-datablock because this is just wasted space.Adjust spacing around
h2andh3titles:Given that
h2titles are always preceded by an horizontal rule, we don't need a lot of space to separate them from the previous section.We also reduce the spacing when a
h2title is followed directly by ah3title.Finally, we add a little spacing below both so that tables are less close to the title.
Pull Request Checklist
Preview: https://pr2081--matrix-spec-previews.netlify.app