Clarifications around third-party invites #2083
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…I links Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
…I links Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
… standard or URL-safe base64. Sydent has been using both alphabets. Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
The exact same thing is said two paragraphs before. Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
Wrap lines at around 100 characters Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a lot of small commits to make changes easy to justify and to review.
I have tried to add more links to other APIs of the spec since this spans across 3 APIs and the links were not obvious unless we read each section. A couple of commits are about formatting the files to wrap lines that were way too long before making actual changes to the files.
The main motivation for this PR is to clarify the base64 encoding of the public keys of the identity server (#2060). Currently Sydent encodes the long-term public key using standard base64, but ephemeral public keys using URL-safe base64. Synapse uses the same python library as Sydent that decodes both indifferently.
Even if we deem that Sydent's behavior is wrong (matrix-org/sydent#593), we still need to document the current behavior, because public keys in
m.room.third_party_eventare used in the authorization rules to validatem.room.memberinvites with athird_party_inviteproperty, so homeservers must be able to handle it.Note that I did not touch the
third_party_signedof/joinbecause it is unclear how or when it is used (#2082).Closes #2060.
Pull Request Checklist
Preview: https://pr2083--matrix-spec-previews.netlify.app