-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for message tags #105
base: master
Are you sure you want to change the base?
Conversation
What's the reason for the This is missing support for unescaping tag values.
that's the right way to do it in a library IMO |
69fbe81
to
d524393
Compare
Escaping should now be working & tested. As far as allowing support, it felt pretty sensible to check for the serverside support before parsing to ensure they support the exact spec we've been working against. Can probably also enable it with account tag or server time caps. I think any sever that wants to offer support for message tags should be broadcasting this though. |
s/escape/unescape/ in your last commit message, and you might want to add a test for that. And having The rest looks good to me (though not tested myself) |
Failing to spot that in the spec for server sent messages, is there a reference somewhere? |
|
Started working on support for prefix-less messages, but didn't fully get there. Will come back to this. |
This enables the bridge to start parsing out messages tags from compliant IRC servers as per https://ircv3.net/specs/extensions/message-tags. It for the moment is very unspecified so all tags are returned as a Map to the client, to then use as it sees fit.